This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
render view one last time in case exception thrown from inside view #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to render the view one last time in case a render.error is triggered. If the view continues to throw exceptions, bail out and just re-throw the exception.
| $e->setError(Application::ERROR_EXCEPTION) | ||
| ->setParam('exception', $ex); | ||
| $events->trigger(MvcEvent::EVENT_RENDER_ERROR, $e); | ||
| } |
There was a problem hiding this comment.
You don't need an else block here; if the condition is met, it won't run continue further regardless.
weierophinney
added a commit
that referenced
this pull request
Jan 14, 2013
ghost
assigned
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to render the view one last time in case a render.error is triggered by an exception from within the view or one of the child views. If the view continues to throw exceptions, bail out and just re-throw the exception.