merge dev to main (v1.12.0) #1190
Conversation
Co-authored-by: Yiming <yiming@whimslab.io> Co-authored-by: Julian BRUXELLE <julian.bruxelle@drone-geofencig.com>
WalkthroughWalkthroughThis update introduces a new GitHub Actions workflow for automating the release process, enhances the JetBrains IDE plugin, improves testing strategies across various packages by incorporating Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (15)
package.jsonis excluded by!**/*.jsonpackages/ide/jetbrains/package.jsonis excluded by!**/*.jsonpackages/language/package.jsonis excluded by!**/*.jsonpackages/misc/redwood/package.jsonis excluded by!**/*.jsonpackages/plugins/openapi/package.jsonis excluded by!**/*.jsonpackages/plugins/swr/package.jsonis excluded by!**/*.jsonpackages/plugins/tanstack-query/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/Post.router.tsis excluded by!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/User.router.tsis excluded by!**/generated/**packages/runtime/package.jsonis excluded by!**/*.jsonpackages/schema/package.jsonis excluded by!**/*.jsonpackages/sdk/package.jsonis excluded by!**/*.jsonpackages/server/package.jsonis excluded by!**/*.jsonpackages/testtools/package.jsonis excluded by!**/*.json
Files selected for processing (18)
- .github/workflows/update-samples.yml (1 hunks)
- packages/ide/jetbrains/build.gradle.kts (1 hunks)
- packages/plugins/openapi/tests/openapi-restful.test.ts (1 hunks)
- packages/plugins/openapi/tests/openapi-rpc.test.ts (1 hunks)
- packages/plugins/tanstack-query/src/generator.ts (5 hunks)
- packages/plugins/tanstack-query/src/runtime/vue.ts (7 hunks)
- packages/plugins/trpc/src/helpers.ts (1 hunks)
- packages/schema/tests/generator/expression-writer.test.ts (1 hunks)
- packages/schema/tests/generator/prisma-generator.test.ts (1 hunks)
- packages/schema/tests/utils.ts (2 hunks)
- packages/testtools/src/model.ts (1 hunks)
- packages/testtools/src/schema.ts (1 hunks)
- tests/integration/tests/cli/config.test.ts (1 hunks)
- tests/integration/tests/cli/format.test.ts (1 hunks)
- tests/integration/tests/cli/generate.test.ts (1 hunks)
- tests/integration/tests/cli/init.test.ts (1 hunks)
- tests/integration/tests/cli/plugins.test.ts (1 hunks)
- tests/integration/tests/plugins/prisma.test.ts (1 hunks)
Additional Context Used
Additional comments not posted (28)
.github/workflows/update-samples.yml (1)
1-27: The GitHub Actions workflow is well-defined and follows best practices for automating the release process by dispatching events to specified repositories. The use of secrets for the token ensures security, and the matrix strategy for repository dispatch is efficiently utilized.tests/integration/tests/cli/format.test.ts (1)
5-5: The addition oftmp.setGracefulCleanup()is a good practice for managing temporary files and directories in tests, contributing to improved test reliability and isolation.tests/integration/tests/plugins/prisma.test.ts (1)
6-6: The inclusion oftmp.setGracefulCleanup()before the Prisma plugin tests is a commendable practice, enhancing test suite reliability through better resource management.tests/integration/tests/cli/config.test.ts (1)
8-8: Addingtmp.setGracefulCleanup()before the CLI Config Tests is a prudent measure, ensuring a clean testing environment by managing temporary files and directories effectively.packages/testtools/src/model.ts (1)
10-10: The inclusion oftmp.setGracefulCleanup()in the test tools module is a valuable addition, promoting a clean testing environment by ensuring the proper cleanup of temporary resources.packages/ide/jetbrains/build.gradle.kts (1)
12-12: Updating the version of the JetBrains IDE plugin to "1.12.0" aligns with the project's overall version increment, reflecting the project's progression and support for users of the JetBrains development environment.packages/schema/tests/utils.ts (3)
10-10: The addition oftmp.setGracefulCleanup()is a positive step towards ensuring a clean testing environment by managing temporary files and directories effectively.
15-28: Refactoring theSchemaLoadingErrorclass constructor for better readability and error handling is a commendable improvement, enhancing the maintainability of the code.
90-92: Improving thesafelyLoadModelfunction by removing unnecessary spaces and enhancing object formatting contributes to the code's readability and maintainability.tests/integration/tests/cli/init.test.ts (1)
12-12: Addingtmp.setGracefulCleanup()before the CLI init command tests is a prudent measure, ensuring a clean testing environment by managing temporary files and directories effectively.packages/plugins/tanstack-query/src/runtime/vue.ts (5)
8-8: The import ofQueryKeytype is correctly added to support the changes in query handling logic.
14-14: The addition oftoValuein the import fromvueis necessary for the new logic that handles Vue refs and reactive values. Ensure thattoValueis being used correctly in the context of Vue 3's reactivity system.
64-80: RefactoringuseModelQueryto usecomputedfor query options is a good practice for Vue 3 composition API, ensuring reactivity. However, ensure thattoValue(args)andtoValue(options)are correctly handling cases whereargsandoptionsmight be refs, reactive objects, or plain values.
98-113: Similar touseModelQuery, the changes inuseInfiniteModelQueryto usecomputedfor query options are appropriate. Again, verify the correct handling oftoValue(args)andtoValue(options)for Vue's reactivity system.
164-170: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [143-187]
The adjustments in
useModelMutationto acceptoptionsas a more flexible type and the use ofcomputedto dynamically handle mutation options are in line with Vue 3's composition API best practices. Ensure that thetoValue(options)usage correctly handles different types of inputs.tests/integration/tests/cli/generate.test.ts (1)
11-11: Addingtmp.setGracefulCleanup()is a good practice to ensure temporary files and directories created during tests are cleaned up afterwards. This helps in avoiding potential side effects across tests and improving test reliability.tests/integration/tests/cli/plugins.test.ts (1)
10-10: The inclusion oftmp.setGracefulCleanup()before the test suite ensures that temporary files are properly cleaned up, which is essential for maintaining a clean testing environment.packages/plugins/openapi/tests/openapi-restful.test.ts (1)
14-14: The addition oftmp.setGracefulCleanup()at the start of the test suite is a good practice for managing temporary files created during testing, ensuring a clean test environment.packages/testtools/src/schema.ts (2)
27-27: Addingtmp.setGracefulCleanup()in the test tools schema setup is a good practice to ensure that temporary files and directories are cleaned up after their use. This is especially important in a library that might be used to run multiple tests in different environments.
27-28: ExportingFILE_SPLITTERandFullDbClientContractprovides useful utilities and types for consumers of the test tools, enhancing the library's usability.packages/plugins/openapi/tests/openapi-rpc.test.ts (1)
14-14: The addition oftmp.setGracefulCleanup()is a good practice for managing temporary files and directories created during tests. This ensures a cleaner test environment and avoids potential side effects from leftover data.packages/plugins/trpc/src/helpers.ts (1)
241-241: Changing the import of$Schemato a namespace import is appropriate if the module exports multiple named exports. Ensure that all usages of$Schemain this file are compatible with this change.packages/schema/tests/generator/prisma-generator.test.ts (1)
11-11: The addition oftmp.setGracefulCleanup()is a good practice for managing temporary files and directories created during tests. This ensures a cleaner test environment and avoids potential side effects from leftover data.packages/plugins/tanstack-query/src/generator.ts (4)
101-101: The modification to usemakeQueryArgsTypefor determining theinputTypeenhances code readability and maintainability by abstracting framework-specific logic.
612-619: The implementation ofmakeQueryArgsTypecorrectly handles framework-specific requirements for input types, particularly for Vue, by supporting reactivity and computed properties.
638-643: The modifications tomakeQueryOptionsfor the Vue target correctly incorporate Vue's reactivity system by allowing options to be reactive or computed, enhancing integration with Vue's composition API.
661-664: The modifications tomakeMutationOptionsfor the Vue target are consistent with the changes inmakeQueryOptions, correctly supporting Vue's reactivity system for mutation options.packages/schema/tests/generator/expression-writer.test.ts (1)
9-9: The addition oftmp.setGracefulCleanup()before the test suite is a good practice for managing temporary resources, ensuring clean up after tests and improving test isolation.
Summary by CodeRabbit
tmp.setGracefulCleanup()across tests for better resource management.