-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to configure migrations configuration files #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for this 🙏
abecd17
to
12d1cc5
Compare
12d1cc5
to
c026dec
Compare
@nikophil not sure how to add a test; my attempt fails and I don’t understand why 🤔 |
hum this error Another thing is that I think we should not have a full test suite with "migration with configuration", or even for "migration" at all. But this goes way beyond the purpose of this PR. What about this: please, remove all the modification about the CI (sorry for your wasted time around it), and let's merge your PR. I've manually tested your branch on a project of mine and can confirm it is working. I will then work on a cleaner solution for this whole thing in the tests |
c026dec
to
631266e
Compare
No worries, I procrastinated a lot on this one..! Reverted every test-related change 🧹 |
631266e
to
01bad5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces a new
orm.reset.migrations.configurations
configuration node allowing a schema reset to rundoctrine:migrations:migrate
for each given configuration. This is useful because usingdoctrine/migrations
, you can only target one single connection or entity manager per configuration file.Fixes #685