refactor: make "database reset" mechanism extendable #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
changed the title
nikophil
commented
Aug 25, 2024
nikophil
force-pushed
the
refactor/database-reset-mechanism
branch
4 times, most recently
from
a29c898 to
d8ef4e7
Compare
nikophil
commented
Aug 27, 2024
|
I have tested this PR and it works great for me. Thank you! |
nikophil
force-pushed
the
refactor/database-reset-mechanism
branch
2 times, most recently
from
411dfb9 to
845b569
Compare
nikophil
commented
Oct 18, 2024
kbond
reviewed
Oct 19, 2024
kbond
approved these changes
Oct 19, 2024
|
If not in the docs, at least in the PR description, I'd like to see an example of hooking into this in userland. |
nikophil
force-pushed
the
refactor/database-reset-mechanism
branch
6 times, most recently
from
d6065db to
0136fdb
Compare
nikophil
force-pushed
the
refactor/database-reset-mechanism
branch
from
0136fdb to
daed4fb
Compare
nikophil
changed the title
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to refactor "database reset" mechanism.
The goal is to decouple the code and to allow end users to extend it, thanks to decoration - I'll add an example in the docs on how to hook in the database reset mechanism
This work was inspired by this comment, I think I also do prefer decoration over an event system in Foundry
fixes #540 #658
(let's merge #686 before this one, I'll take care of the rebase)done