tests: transform "migrate" testsuite into "reset database" testsuite #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
tests/reset-scheam-testsuite
branch
from
08ef3be to
76a6fed
Compare
nikophil
force-pushed
the
tests/reset-scheam-testsuite
branch
3 times, most recently
from
57c7926 to
01485a7
Compare
nikophil
commented
Jan 5, 2025
nikophil
force-pushed
the
tests/reset-scheam-testsuite
branch
from
01485a7 to
951ef94
Compare
kbond
approved these changes
Jan 23, 2025
nikophil
force-pushed
the
tests/reset-scheam-testsuite
branch
from
951ef94 to
e446f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my initial goal, when I split the test suite: to have a "reset database" testsuite, and a main test suite.
Another cool thing is that I've moved all the tests related to "global story" here. Each time I have some complex stuff to debug in the main testsuite, I always deactivate the global stories, because it creates some noise (extra pass in
create()method, for example)something I'm wondering is maybe we can now remove some permutations for the main testsuite in the CI. maybe remove sqlite and pgsql permutations, always use dama... WDYT?
todo: add to the "reset database" matrix
--prefer-lowestpermutation