fix: simplify reset database extension #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
force-pushed
the
fix/database-reset-extension
branch
from
ea20d5a to
82d1f29
Compare
nikophil
force-pushed
the
fix/database-reset-extension
branch
from
82d1f29 to
a95929c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #770
fixes #771 (I guess 😅)
At first, I used private services names for the resetters, and added a public alias (
OrmResetter) which purpose was to be used to decorate the resetters (see docs). But this was clumsy, because when decorating an alias, the decorator does not inherit the tags from the decorated. Which made the whole extension system complex.Now, the resetter service name is directly the name of the service which needs to be decorated, as stated in the docs. No more alias.
I've also added some tests so we know it just work
ping @Nyholm @javiereguiluz this is going to land in the next release :)