-
Notifications
You must be signed in to change notification settings - Fork 8
Update to v6.2.0 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes requested in ARM-software#208
Removes error: error: old-style function definition [-Werror=old-style-definition]
Bit shift in accordance with IRQn % 16 was incorrect, and masking was needed to extract only the IRQn bits. Both fixed.
…ware#225) - remove references to deprecated HCI driver
Fix documentation of the Register HPPIR_INTID according to "ARM Generic Interrupt Controller Architecture version 2.0 Architecture Specification" Table 4-41 GICC_HPPIR bit assignments 
Inline assembler constraints were incorrect Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
Inline assembler constraints were incorrect. Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
|
Hi @tpambor thank you for taking the initiative. Before I approve this, may I ask what method did you chose to pick the commits? I would prefer to have |
|
Hi, I first merged v6.2.0 but that made the pipeline fail as the commit adopting for Zephyr was not present. I then updated the branch and rebased on top of master of this repo. This PR includes all commits from upstream until v6.2.0 from when it was forked. |
|
HI @tpambor could you try this instead? This is how my branch looks with these steps: main...wearyzen:CMSIS_6:cmsis_6_update_v6.2.0 |
|
Could be done like that. I think the downside is that this would remove the commit that current west.yml points to and could break things for anyone still using the old commit hash. I have seen the method I used for other modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
Currently main is based on 783317a, a commit between v6.1.0 and v6.2.0, which is not an official release. As recommended by the upstream repository, "For stable versions ready for productive use please refer to tagged releases, like CMSIS 6.2.0." This update ensures that our project is aligned with a stable, supported, and production-ready version of CMSIS6.
This upgrade is a proactive measure to prepare for the upcoming Zephyr 4.2.0 release.