Skip to content

Conversation

@tpambor
Copy link

@tpambor tpambor commented Jun 20, 2025

Currently main is based on 783317a, a commit between v6.1.0 and v6.2.0, which is not an official release. As recommended by the upstream repository, "For stable versions ready for productive use please refer to tagged releases, like CMSIS 6.2.0." This update ensures that our project is aligned with a stable, supported, and production-ready version of CMSIS6.

This upgrade is a proactive measure to prepare for the upcoming Zephyr 4.2.0 release.

KeilChris and others added 22 commits June 20, 2025 19:29
Removes error:
error: old-style function definition [-Werror=old-style-definition]
Bit shift in accordance with IRQn % 16 was incorrect, and masking was
needed to extract only the IRQn bits. Both fixed.
)

Need to be tested /reviewed, as I am not sure about the flag control
logic.
Fix documentation of the Register HPPIR_INTID according to
"ARM Generic Interrupt Controller Architecture version 2.0 Architecture
Specification"
Table 4-41 GICC_HPPIR bit assignments


![409053189-dfa13d3e-1650-489b-a8f2-b061ac9afe17](https://github.com/user-attachments/assets/919edcce-ce77-450b-8839-af6555f2249a)
Inline assembler constraints were incorrect

Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
Inline assembler constraints were incorrect.

Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
@wearyzen
Copy link
Collaborator

Hi @tpambor thank you for taking the initiative. Before I approve this, may I ask what method did you chose to pick the commits? I would prefer to have git rebase v6.2.0 so that its easier to compare the history with upstream

@tpambor
Copy link
Author

tpambor commented Jun 23, 2025

Hi, I first merged v6.2.0 but that made the pipeline fail as the commit adopting for Zephyr was not present. I then updated the branch and rebased on top of master of this repo. This PR includes all commits from upstream until v6.2.0 from when it was forked.

@wearyzen
Copy link
Collaborator

HI @tpambor could you try this instead?

git remote add upupstream https://github.com/ARM-software/CMSIS_6.git
git fetch upupstream
git rebase v6.2.0

This is how my branch looks with these steps: main...wearyzen:CMSIS_6:cmsis_6_update_v6.2.0

@tpambor
Copy link
Author

tpambor commented Jun 23, 2025

Could be done like that. I think the downside is that this would remove the commit that current west.yml points to and could break things for anyone still using the old commit hash.

I have seen the method I used for other modules.

Copy link
Collaborator

@wearyzen wearyzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@wearyzen wearyzen merged commit 06d952b into zephyrproject-rtos:main Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.