Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfx_glue: Define NRFX_ASSERT as __ASSERT_NO_MSG #24

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

anangl
Copy link
Member

@anangl anangl commented Feb 17, 2020

Use __ASSERT_NO_MSG directly, not through the assert macro that comes
from libc, as the definition of the latter might be different when
some specific libc version is used, and this could generate troubles.

Signed-off-by: Andrzej Głąbek andrzej.glabek@nordicsemi.no

Use __ASSERT_NO_MSG directly, not through the assert macro that comes
from libc, as the definition of the latter might be different when
some specific libc version is used, and this could generate troubles.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
@anangl anangl added the enhancement New feature or request label Feb 17, 2020
@anangl
Copy link
Member Author

anangl commented Feb 17, 2020

cc @koffes

Copy link

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@carlescufi carlescufi merged commit 62f9c63 into zephyrproject-rtos:master Feb 17, 2020
@anangl anangl deleted the correct_nrfx_assert branch February 18, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants