modules: hal: nordic: Define NRFX_ASSERT as __ASSERT_NO_MSG #22869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
added
Enhancement
anangl
added
area: Modules
Blocked
anangl
force-pushed
the
correct_nrfx_asssert
branch
from
3431c7b to
682eb71
Compare
anangl
force-pushed
the
correct_nrfx_asssert
branch
from
682eb71 to
e8d8690
Compare
carlescufi
approved these changes
Feb 17, 2020
anangl
force-pushed
the
correct_nrfx_asssert
branch
from
e8d8690 to
1f8226d
Compare
|
Updated hal_nordic's SHA. |
anangl
removed
Blocked
ioannisg
approved these changes
Feb 19, 2020
Update hal_nordic's revision, so that NRFX_ASSERT uses __ASSERT_NO_MSG directly, not through the assert macro that comes from from libc, as the definition of the latter might be different when some specific libc version is used, and this could generate troubles. Replace also uses of assert() with __ASSERT_NO_MSG() in nrfx driver shims that use this macro without including the corresponding header file (i.e. that implicitly rely on assert.h being included from nrfx_glue.h, which is no longer the case). Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
force-pushed
the
correct_nrfx_asssert
branch
from
1f8226d to
e75953e
Compare
|
Rebased on master. |
This was referenced Feb 27, 2020
|
Closing this one, as the changes it brings are included in #23125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update hal_nordic's revision, so that NRFX_ASSERT uses __ASSERT_NO_MSG
directly, not through the assert macro that comes from from libc,
as the definition of the latter might be different when some specific
libc version is used, and this could generate troubles.
Replace also uses of assert() with __ASSERT_NO_MSG() in nrfx driver
shims that use this macro without including the corresponding header
file (i.e. that implicitly rely on assert.h being included from
nrfx_glue.h, which is no longer the case).
Signed-off-by: Andrzej Głąbek andrzej.glabek@nordicsemi.no
zephyrproject-rtos/hal_nordic#24 needs to be merged first.
Fixes #22541