vl53l0x: Cast unsigned abs param to signed type to fix clang warning #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
approved these changes
Mar 31, 2023
erwango
approved these changes
Mar 31, 2023
Member
|
I agree with the change, and I'll report it internally. Would you mind adding a note in the component README file ( |
FixPoint1616_t is typedef'd to uint32_t. The result of dividing two variables of that type is also unsigned. Passing an unsigned value to abs doesn't make sense. Cast the value to int32_t in case the computaton of diff1_mcps generates a negative result so that xTalkCorrection doesn't end up with a huge value. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
unsigned-abs
branch
from
a91e366 to
36120c2
Compare
Contributor
Author
That's a good plan. Done. |
Member
Thanks. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixPoint1616_t is typedef'd to uint32_t. The result of dividing two variables of that type is also unsigned. Passing an unsigned value to abs doesn't make sense.
Cast the value to int32_t in case the computaton of diff1_mcps generates a negative result so that xTalkCorrection doesn't end up with a huge value.