Clang fixes when building without -ffreestanding #56396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
requested review from
andyross,
dcpleung,
nandojve,
nashif,
rlubos and
tbursztyka
as code owners
keith-packard
force-pushed
the
clang-fixes
branch
from
39b969e to
bc2af9f
Compare
zephyrbot
added
manifest
manifest-hal_st
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
keith-packard
force-pushed
the
clang-fixes
branch
from
65624bb to
d9f7ba0
Compare
peter-mitsis
previously approved these changes
Mar 31, 2023
Contributor
Author
|
This depends on pr #56489 |
Member
It's merged now |
Contributor
Author
Thanks! |
Member
|
@keith-packard could you update this PR to remove the change to |
This case takes a float value and passes it to the integer abs function, storing the result in an integer type variable. That looks like a possible error to clang, so insert an explicit cast to int to make the compiler happy. Signed-off-by: Keith Packard <keithp@keithp.com>
C only permits labels on statements, not declarations. Separate the declarations from the assignments so that the labels can target statements instead. Signed-off-by: Keith Packard <keithp@keithp.com>
Clang complains when an unsigned value is passed to abs, even though there is an implicit cast to a signed type. Insert an explicit cast to make clang happy. Signed-off-by: Keith Packard <keithp@keithp.com>
Clang detects a value of the wrong size passed to printf with %h or %hh modifiers. Insert explicit casts to the expected type. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
clang-fixes
branch
from
d9f7ba0 to
9c07fb3
Compare
Contributor
Author
done. |
keith-packard
force-pushed
the
clang-fixes
branch
from
9c07fb3 to
53b99d4
Compare
keith-packard
removed
DNM
gmarull
approved these changes
Apr 5, 2023
rlubos
approved these changes
Apr 5, 2023
carlescufi
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #54638 proposes eliminating -ffreestanding when building with a C library other than the minimal C library. When building in this mode, clang finds a number of things to complain about in the code, including calls to abs with unsigned/float values and inappropriate types to printf.
This series also includes a C language conformance fix -- code using labels on declarations, which is not valid.