Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors when running sanitycheck with tests/subsys/storage/stream/stream_flash #25057

Closed
galak opened this issue May 7, 2020 · 1 comment · Fixed by #25070
Closed

errors when running sanitycheck with tests/subsys/storage/stream/stream_flash #25057

galak opened this issue May 7, 2020 · 1 comment · Fixed by #25070
Assignees
@hakonfam
Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@galak
Copy link
Collaborator

galak commented May 7, 2020 

ERROR   - /home/galak/git/zephyr/tests/subsys/storage/stream/stream_flash/src/main.c: found invalid #ifdef, #endif in ztest_test_suite()
ERROR   - /home/galak/git/zephyr/tests/subsys/storage/stream/stream_flash/src/main.c: found invalid #ifdef, #endif in ztest_test_suite()
ERROR   - /home/galak/git/zephyr/tests/subsys/storage/stream/stream_flash/src/main.c: found invalid #ifdef, #endif in ztest_test_suite()
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label May 7, 2020
@galak
Copy link
Collaborator Author

galak commented May 7, 2020

You aren't allowed to have an #ifdef in ztest_test_suite, thus the error message here.

@galak galak added area: Tests Issues related to a particular existing or missing test priority: medium Medium impact/importance bug labels May 7, 2020
hakonfam added a commit to hakonfam/zephyr that referenced this issue May 7, 2020
@hakonfam
tests: storage: remove ifdef from ztest_test_suite
358f05d 
Having #ifdefs inside 'ztest_test_suite' makes sanitycheck fail.
Move the #ifdef's inside the test function itself instead to
avoid the failure.

This fixes issue zephyrproject-rtos#25057

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
@hakonfam hakonfam mentioned this issue May 7, 2020
Closed
@galak galak linked a pull request May 7, 2020 that will close this issue
tests: stream_flash: skip tests correctly #25070
Merged
@nashif nashif mentioned this issue May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hakonfam hakonfam

Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
2 participants
@hakonfam @galak