Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: storage: remove ifdef from ztest_test_suite #25058

Closed

Conversation

hakonfam
Copy link
Collaborator

@hakonfam hakonfam commented May 7, 2020

Having #ifdefs inside 'ztest_test_suite' makes sanitycheck fail.
Move the #ifdef's inside the test function itself instead to
avoid the failure.

Fixes #25057

Signed-off-by: Håkon Øye Amundsen haakon.amundsen@nordicsemi.no

Having #ifdefs inside 'ztest_test_suite' makes sanitycheck fail.
Move the #ifdef's inside the test function itself instead to
avoid the failure.

This fixes issue zephyrproject-rtos#25057

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
@hakonfam hakonfam requested a review from galak May 7, 2020 06:16
@hakonfam hakonfam requested a review from nashif as a code owner May 7, 2020 06:16
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label May 7, 2020
Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a ztest_test_skip(); in an #else block?

@carlescufi carlescufi added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label May 7, 2020
@nashif
Copy link
Member

nashif commented May 7, 2020

did not see this until after I submitted #25070

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct fix with an exception raised by sanitycheck to catch this in the future available here: 25070

@hakonfam hakonfam closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Tests Issues related to a particular existing or missing test Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors when running sanitycheck with tests/subsys/storage/stream/stream_flash
6 participants