Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldp: lldp_send includes bug #25184

Closed
ehudmarvell opened this issue May 10, 2020 · 0 comments · Fixed by #25192
Closed

lldp: lldp_send includes bug #25184

ehudmarvell opened this issue May 10, 2020 · 0 comments · Fixed by #25192
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug

Comments

@ehudmarvell
Copy link
Contributor

Hi,

I am enable lldp in my env, after fixing the following bug it seem working
#25084

but while I am using optional lldp fields it isn't.

according to lldp_send:

if (lldp->optional_du && lldp->optional_len) {
if (!net_pkt_write(pkt, (u8_t *)lldp->optional_du,
lldp->optional_len)) {
net_pkt_unref(pkt);
ret = -ENOMEM;
goto out;
}
}

why net_pkt_write with '!' before? if everything good net_pkt_write return 0.
if I remove the '!' it is working fine.

Environment:
Zephyr SDK
Commit SHA :6933248e0cb4f7af31e2bab5b39c594806ab53ac

Thanks,
Ehud

@ehudmarvell ehudmarvell added the bug The issue is a bug, or the PR is fixing a bug label May 10, 2020
jukkar added a commit to jukkar/zephyr that referenced this issue May 11, 2020
Make sure that net_pkt_write() sets the LLDPDU data correctly
in net_pkt.

Fixes zephyrproject-rtos#25184

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
carlescufi pushed a commit that referenced this issue May 11, 2020
Make sure that net_pkt_write() sets the LLDPDU data correctly
in net_pkt.

Fixes #25184

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
Make sure that net_pkt_write() sets the LLDPDU data correctly
in net_pkt.

Fixes zephyrproject-rtos#25184

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants