Fix LLDP packet format #25192
Merged
Fix LLDP packet format #25192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that net_pkt_write() sets the LLDPDU data correctly in net_pkt. Fixes zephyrproject-rtos#25184 Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
tbursztyka
approved these changes
May 11, 2020
pfl
reviewed
May 11, 2020
Make sure that we have proper network interface which support VLAN and LLDP in this sample. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
jukkar
force-pushed
the
issue-25184-lldp-pkt-write
branch
from
09f5d7a to
edde183
Compare
pfl
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLDP net_pkt was not created as the code did not properly check the return value of net_pkt_write() call.
Fixes #25184