-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext/hal/st/stm32cube/stm32l1xx: rename SVC_IRQn -> SVCall_IRQn #15744
Conversation
SVCall_IRQn is used as enum value for SV Call Interrupt for Cortex-M based SoCs for which CPU_CORTEX_M_HAS_BASEPRI=y. However stm32cube for stm32l1xx uses SVC_IRQn enum value for this purpose. This leads to this error: arch/arm/include/cortex_m/exc.h:101:19: error: 'SVCall_IRQn' undeclared (first use in this function); did you mean 'SVC_IRQn'? NVIC_SetPriority(SVCall_IRQn, _EXC_SVC_PRIO); ^~~~~~~~~~~ SVC_IRQn NB: ext/hal/st/stm32cube/stm32l1xx/soc/stm32l151xb.h file was already fixed in 9f82604 ('ext: hal: st: stm32cube: Add HAL for the STM32L1x series'). Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Thanks for submitting.
Sorry if this was not clear but please fix them all at once in current PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add fix for stm32l151xb.h
The ext/hal/st/stm32cube/stm32l1xx/soc/stm32l151xb.h file was already The commit 9f82604 is already merged into the master. I can't fix it if it is already fixed! I can make PR with two commits:
The problem is that the first commit will break 96b_wistrio board. |
fbb9993
to
94ace28
Compare
@frantony, thanks for clarification and my bad then. Twice my bad, since I reviewed and approved L1 porting. Thanks for your proposal, but let's do it simple: |
94ace28
to
fbb9993
Compare
I have just done it. |
SVCall_IRQn is used as enum value for SV Call Interrupt for Cortex-M
based SoCs for which
CPU_CORTEX_M_HAS_BASEPRI=y
. However stm32cubefor stm32l1xx uses SVC_IRQn enum value for this purpose.
This leads to this error:
NB: ext/hal/st/stm32cube/stm32l1xx/soc/stm32l151xb.h file was already
fixed in 9f82604 ('ext: hal: st: stm32cube: Add HAL for the STM32L1x series').