Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: hal: cmsis: Add CMSIS-Core(R). #19964

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

stephanosio
Copy link
Member

This commit adds a preliminary implementation of CMSIS-Core(R) for use
with the ARM Cortex-R port.

At this time, CMSIS-Core(R) is not merged back into the upstream CMSIS
repository and therefore is not available from official sources.

Until upstream merge happens, the preliminary version can be obtained
from the following URL:

https://github.com/stephanosio/CMSIS_5/tree/core_r

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>

This PR is part of the preparations for #19644.

This commit adds a preliminary implementation of CMSIS-Core(R) for use
with the ARM Cortex-R port.

At this time, CMSIS-Core(R) is not merged back into the upstream CMSIS
repository and therefore is not available from official sources.

Until upstream merge happens, the preliminary version can be obtained
from the following URL:

https://github.com/stephanosio/CMSIS_5/tree/core_r

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
Add stephanosio as a code owner for /ext/hal/cmsis/.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
@stephanosio stephanosio requested a review from ioannisg October 19, 2019 13:23
@zephyrbot zephyrbot added the EXT Has change or related to ext/ (obsolete) label Oct 19, 2019
@stephanosio stephanosio added area: ARM ARM (32-bit) Architecture EXT Has change or related to ext/ (obsolete) and removed EXT Has change or related to ext/ (obsolete) labels Oct 19, 2019
@stephanosio stephanosio mentioned this pull request Oct 19, 2019
32 tasks
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea Arm was working on CMSIS for Cortex-R but this looks good to me.

@carlescufi
Copy link
Member

@stephanosio could you please provide the source that you used to populate your https://github.com/stephanosio/CMSIS_5/tree/core_r repository?

@stephanosio
Copy link
Member Author

@carlescufi This is my own work. I'm planning to make a PR back to the ARM upstream repo after this gets more mature (for now, no MPU support is available in this version).

Some Cortex-R support related issues in upstream CMSIS:
ARM-software/CMSIS_5#314
ARM-software/CMSIS_5#596

@ioannisg ioannisg requested a review from nashif October 20, 2019 09:24
@ioannisg ioannisg added the Feature A planned feature with a milestone label Oct 20, 2019
@ioannisg ioannisg added this to the v2.1.0 milestone Oct 20, 2019
@ioannisg ioannisg added the Release Notes To be mentioned in the release notes label Oct 20, 2019
@ioannisg
Copy link
Member

@galak @nashif @MaureenHelm how can we proceed with this?

@nashif nashif merged commit a31672c into zephyrproject-rtos:master Oct 22, 2019
@stephanosio stephanosio deleted the cmsis_core_r branch October 22, 2019 13:58
stephanosio added a commit to stephanosio/zephyr that referenced this pull request Nov 5, 2019
This commit updates the Cortex-R port to use the preliminary
CMSIS-Core(R) implementation added in the PR zephyrproject-rtos#19964.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio added a commit to stephanosio/zephyr that referenced this pull request Nov 5, 2019
This commit updates the 'xilinx_zynqmp' SoC initialisation code to use
the preliminary CMSIS-Core(R) implementation added in the PR zephyrproject-rtos#19964.

In addition, it also defines the Core IP revision value for the SoC as
specified in the Zynq UltraScale+ Device Technical Reference Manual.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARM ARM (32-bit) Architecture EXT Has change or related to ext/ (obsolete) Feature A planned feature with a milestone Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants