arch: arm: Make PLATFORM_SPECIFIC_INIT available to all ARM variants. #20468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move PLATFORM_SPECIFIC_INIT declaration from Cortex-M Kconfig to the ARM arch Kconfig in order to make it available for all ARM variants. The rationale is that there is really no good reason why platform-specific initialisation should be a Cortex-M-specific feature and that Cortex-R port is expected to utilise this in a near future. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio
requested review from
galak,
ioannisg and
MaureenHelm
as code owners
ioannisg
approved these changes
Nov 8, 2019
galak
approved these changes
Nov 8, 2019
11 tasks
galak
requested changes
Nov 8, 2019
Is there a public declaration for z_platform_init? |
I think that's just used inside reset.S |
@ioannisg Not at this time. It is more like an implicit contract between arch reset.S and soc when PLATFORM_SPECIFIC_INIT is enabled. |
Yes, and I am happy for it being like this :) |
galak
approved these changes
Nov 8, 2019
ioannisg
reviewed
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PLATFORM_SPECIFIC_INIT declaration from Cortex-M Kconfig to the
ARM arch Kconfig in order to make it available for all ARM variants.
The rationale is that there is really no good reason why
platform-specific initialisation should be a Cortex-M-specific feature
and that Cortex-R port is expected to utilise this in a near future.
Signed-off-by: Stephanos Ioannidis root@stephanos.io
NOTE: Separated out from #19698 for timely review and merging.