Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: sensors: isl29035: add sample #21434

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Dec 16, 2019

Add a sample to demonstrate and test the Renesas/Intersil ISL29035 light sensor driver.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of doc tweaks, then LGTM.

every 2 seconds.

If trigger is enabled the sample displays light intensity from the
ISL29035 sensor as long every 10 seconds if it is within +/- 50 lux of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd delete as long

ISL29035 sensor as long every 10 seconds if it is within +/- 50 lux of
the last read sample. If the sensor detects an intensity outside that
range the application wakes, displays the intensity, resets the
window, then continues as before.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to resets the 10-second window

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually the intensity range window, not the time window. Updated, along with the delete requested above. Please re-check; thanks.

Add a sample to demonstrate and test the Renesas/Intersil ISL29035
light sensor driver.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for doc changes, thanks!

@MaureenHelm MaureenHelm merged commit 50a54f4 into zephyrproject-rtos:master Dec 18, 2019
@pabigot pabigot deleted the nordic/20191216d branch December 19, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants