-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: sensors: isl29035: add sample #21434
samples: sensors: isl29035: add sample #21434
Conversation
cdaacf5
to
1f8b51a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of doc tweaks, then LGTM.
samples/sensor/isl29035/README.rst
Outdated
every 2 seconds. | ||
|
||
If trigger is enabled the sample displays light intensity from the | ||
ISL29035 sensor as long every 10 seconds if it is within +/- 50 lux of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd delete as long
samples/sensor/isl29035/README.rst
Outdated
ISL29035 sensor as long every 10 seconds if it is within +/- 50 lux of | ||
the last read sample. If the sensor detects an intensity outside that | ||
range the application wakes, displays the intensity, resets the | ||
window, then continues as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to resets the 10-second window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually the intensity range window, not the time window. Updated, along with the delete requested above. Please re-check; thanks.
Add a sample to demonstrate and test the Renesas/Intersil ISL29035 light sensor driver. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
1f8b51a
to
de7fc8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for doc changes, thanks!
Add a sample to demonstrate and test the Renesas/Intersil ISL29035 light sensor driver.