Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPIC-GPIO] drivers: sensor: isl29035: update to new GPIO API #21523

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Dec 19, 2019

Document alert pin behavior, switch to new API.

NOTE: This includes the content of #21434 which should disappear when this is topic-gpio is rebased on master. Only the top commit is relevant to this PR.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 19, 2019

All checks passed.

checkpatch (informational only, not a failure)

-:93: WARNING:LONG_LINE: line over 80 characters
#93: FILE: drivers/sensor/isl29035/isl29035_trigger.c:183:
+	gpio_pin_configure(drv_data->gpio, DT_INST_0_ISIL_ISL29035_INT_GPIOS_PIN,

-:94: WARNING:LONG_LINE: line over 80 characters
#94: FILE: drivers/sensor/isl29035/isl29035_trigger.c:184:
+			   GPIO_INPUT | DT_INST_0_ISIL_ISL29035_INT_GPIOS_FLAGS);

- total: 0 errors, 2 warnings, 125 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM.

@carlescufi
Copy link
Member

@MaureenHelm can you please review
@pabigot please rebase

Document alert pin behavior, switch to new API.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 17, 2020

Rebase wasn't needed, but there were some build errors and problems with non-default triggers. Verified and tested again.

@pabigot
Copy link
Collaborator Author

pabigot commented Jan 19, 2020

Sanity check failure due to #21568, open for four weeks with no assignee. IMO this should be mergeable.

@MaureenHelm MaureenHelm merged commit a6402d3 into zephyrproject-rtos:topic-gpio Jan 21, 2020
@pabigot pabigot deleted the gpio/isl29035 branch January 21, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants