Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: nucleo_f030r8: use smaller board image #21705

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

frantony
Copy link
Contributor

@frantony frantony commented Jan 4, 2020

At the moment we have different images for for Nucleo F030R8 and Nucleo F070RB boards, the images have the same pixel size but different file formats, e.g:

  NAMES="f030r8 f070rb"
  for i in $NAMES; do
    file boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg;
  done


  boards/arm/nucleo_f030r8/doc/img/nucleo_f030r8.jpg: JPEG image data,
  Exif standard: [TIFF image data, little-endian, direntries=0], baseline,
  precision 8, 500x367, frames 3
  boards/arm/nucleo_f070rb/doc/img/nucleo_f070rb.jpg: JPEG image data,
  JFIF standard 1.01, aspect ratio, density 1x1, segment length 16,
  progressive, precision 8, 500x367, frames 3

The nucleo_f030r8.jpg file is larger:

  for i in $NAMES; do
    ls -1 -sh boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg;
  done

  128K boards/arm/nucleo_f030r8/doc/img/nucleo_f030r8.jpg
  40K boards/arm/nucleo_f070rb/doc/img/nucleo_f070rb.jpg

Applying simultaneous black/white threshold to the images and comparing them with imagemagick tools shows that the images have no significant difference.

  for i in $NAMES; do
    convert boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg \
            -threshold 80% /tmp/$i.png;
  done
  compare $(for i in $NAMES; do echo -n  "/tmp/$i.png "; done) \
            -compose src /tmp/diff.png

See also 'boards: arm: unify Nucleo-64 boards connectors image' (#15926).

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 4, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@erwango erwango added the platform: STM32 ST Micro STM32 label Jan 6, 2020
At the moment we have different images for
for Nucleo F030R8 and Nucleo F070RB boards,
the images have the same pixel size but different
file formats, e.g:

  NAMES="f030r8 f070rb"
  for i in $NAMES; do
    file boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg;
  done

  boards/arm/nucleo_f030r8/doc/img/nucleo_f030r8.jpg: JPEG image
  data, Exif standard: [TIFF image data, little-endian,
  direntries=0], baseline, precision 8, 500x367, frames 3
  boards/arm/nucleo_f070rb/doc/img/nucleo_f070rb.jpg: JPEG image
  data, JFIF standard 1.01, aspect ratio, density 1x1,
  segment length 16, progressive, precision 8, 500x367, frames 3

The nucleo_f030r8.jpg file is larger:

  for i in $NAMES; do
    ls -1 -sh boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg;
  done

  128K boards/arm/nucleo_f030r8/doc/img/nucleo_f030r8.jpg
  40K boards/arm/nucleo_f070rb/doc/img/nucleo_f070rb.jpg

Applying simultaneous black/white threshold to the images
and comparing them with imagemagick tools shows that
the images have no significant difference.

  for i in $NAMES; do
    convert boards/arm/nucleo_$i/doc/img/nucleo_$i.jpg \
            -threshold 80% /tmp/$i.png;
  done
  compare $(for i in $NAMES; do echo -n  "/tmp/$i.png "; done) \
            -compose src /tmp/diff.png

See also 'boards: arm: unify Nucleo-64 boards connectors image'
(zephyrproject-rtos#15926).

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
@erwango erwango requested a review from MaureenHelm January 6, 2020 14:12
@MaureenHelm MaureenHelm merged commit 0107973 into zephyrproject-rtos:master Jan 6, 2020
@frantony frantony deleted the nucleo_f030r8.img branch January 6, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants