Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: nrf9160dk: Add support for newer revisions (0.14.0+) of the DK #31624

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

anangl
Copy link
Member

@anangl anangl commented Jan 26, 2021

  • Use devicetree instead of Kconfig to configure the board control switches in nRF9160 DK:

    • add binding for the switches that provide optional signal routings on this board
    • add binding for the GPIO interface that can be used for communication (e.g. UART based) between the nRF9160 and the nRF52840 on the DK, and add GPIO mapping for this interface so that its lines can be used without caring about of actual pin numbers on both sides
    • add binding for one GPIO line chosen from the above interface that is to allow the nRF9160 to reset the nRF52840
    • update accordingly dts files and board specific code for both board definitions associated with the DK
    • introduce .dtsi files that can be included from dts overlays in order to facilitate the use of the above GPIO interface; modify the overlay in the hci_uart sample to provide an example of use of those files
  • Use the multiple board revisions feature to provide support for the new hardware possibilities available in nRF9160 DK starting from v0.14.0.

  • Add DT node and .dtsi files that allow using the PCAL6408A I/O expander that is available in nRF9160 DK v0.14.0 or later to interface LEDs and buttons on the DK

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like BOARD_REVISION/BOARD_REVISION_STRING need documentation somewhere.

@tejlmand
Copy link
Collaborator

tejlmand commented Feb 1, 2021

Feels like BOARD_REVISION/BOARD_REVISION_STRING need documentation somewhere.

If you consider the board revision feature itself, then that is documented here:
https://docs.zephyrproject.org/latest/guides/porting/board_porting.html#multiple-board-revisions

If you refer to this commit: f817ff3
then there is a dedicated PR for that here: #31617

If you mean you would like to see dedicated documentation for those, then it's probably outside the scope of this PR, but I agree that we have too limited documentation for Zephyr / CMake in general.
Updated #9947 with additional content.

@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch from 0e08d09 to 13785c9 Compare February 2, 2021 14:14
@anangl
Copy link
Member Author

anangl commented Feb 2, 2021

Rebased on #31864.

@anangl anangl added the Blocked Blocked by another PR or issue label Feb 2, 2021
@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch 5 times, most recently from 6bd4220 to f03bb8e Compare February 3, 2021 11:14
@anangl
Copy link
Member Author

anangl commented Feb 3, 2021

Rebased on master after #31864 has been merged.

@anangl anangl removed the Blocked Blocked by another PR or issue label Feb 3, 2021
@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch from f03bb8e to a44d657 Compare February 3, 2021 13:32
@anangl
Copy link
Member Author

anangl commented Feb 3, 2021

Rebased on #31926.

@anangl anangl added the Blocked Blocked by another PR or issue label Feb 3, 2021
@carlescufi carlescufi requested a review from pabigot February 8, 2021 15:18
@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch from a44d657 to 7b69dc6 Compare February 8, 2021 17:36
@anangl anangl marked this pull request as ready for review February 8, 2021 17:37
@anangl anangl requested a review from jhedberg as a code owner February 8, 2021 17:37
@carlescufi carlescufi requested review from jfischer-no and removed request for ulfalizer, jhedberg, joerchan, Vudentz and mnkp February 17, 2021 11:08
@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch from 08c2015 to b96c694 Compare February 19, 2021 11:36
@anangl
Copy link
Member Author

anangl commented Feb 19, 2021

Rebased to make CI green.

# Copyright (c) 2021 Nordic Semiconductor ASA
# SPDX-License-Identifier: Apache-2.0

# NOTE: This file is replicated in nrf9160dk_nrf9160 and nrf9160dk_nrf52840.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything against having only nrf9160dk directory for both boards nrf9160dk_nrf9160 and nrf9160dk_nrf52840?

drivers/gpio/CMakeLists.txt Outdated Show resolved Hide resolved
@anangl
Copy link
Member Author

anangl commented Mar 1, 2021

Rebased on #32748.

@anangl anangl added the Blocked Blocked by another PR or issue label Mar 1, 2021
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm once unblocked.

anangl added 3 commits March 3, 2021 09:47
Use devicetree instead of Kconfig to configure the board control
switches in nRF9160 DK:
- add binding for the switches that provide optional signal routings
  on this board
- add binding for the GPIO interface that can be used for communication
  (e.g. UART based) between the nRF9160 and the nRF52840 on the DK,
  and add GPIO mapping for this interface so that its lines can be used
  without caring about of actual pin numbers on both sides
- add binding for one GPIO line chosen from the above interface that is
  to allow the nRF9160 to reset the nRF52840
- update accordingly dts files and board specific code for both board
  definitions associated with the DK
- introduce .dtsi files that can be included from dts overlays in order
  to facilitate the use of the above GPIO interface; modify the overlay
  in the hci_uart sample to provide an example of use of those files

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Use the multiple board revisions feature to provide support for the new
hardware possibilities available in nRF9160 DK starting from v0.14.0.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Add devicetree node representing the PCAL6408A I2C-based I/O expander
that is available in nRF9160 DK v0.14.0 or later.
Provide also .dtsi files that can be used in applications to simplify
switching to interfacing onboard LEDs and buttons through this expander
instead of SoC pins.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
@anangl anangl force-pushed the nrf9160dk_rev_0_14 branch from 7836eeb to cbb0de3 Compare March 3, 2021 08:48
@anangl
Copy link
Member Author

anangl commented Mar 3, 2021

Rebased after #32748 has been merged.

@anangl anangl removed the Blocked Blocked by another PR or issue label Mar 3, 2021
@ioannisg ioannisg requested review from ru-fu, jfischer-no and galak March 3, 2021 13:44
Copy link
Collaborator

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good.

@ioannisg ioannisg merged commit 763e73d into zephyrproject-rtos:master Mar 4, 2021
@anangl anangl deleted the nrf9160dk_rev_0_14 branch March 4, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants