-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: nrf9160dk: Add support for newer revisions (0.14.0+) of the DK #31624
Conversation
495f8ce
to
0e08d09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like BOARD_REVISION/BOARD_REVISION_STRING need documentation somewhere.
If you consider the board revision feature itself, then that is documented here: If you refer to this commit: f817ff3 If you mean you would like to see dedicated documentation for those, then it's probably outside the scope of this PR, but I agree that we have too limited documentation for Zephyr / CMake in general. |
0e08d09
to
13785c9
Compare
Rebased on #31864. |
6bd4220
to
f03bb8e
Compare
Rebased on master after #31864 has been merged. |
f03bb8e
to
a44d657
Compare
Rebased on #31926. |
a44d657
to
7b69dc6
Compare
08c2015
to
b96c694
Compare
Rebased to make CI green. |
b96c694
to
f0644f2
Compare
# Copyright (c) 2021 Nordic Semiconductor ASA | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
# NOTE: This file is replicated in nrf9160dk_nrf9160 and nrf9160dk_nrf52840. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything against having only nrf9160dk directory for both boards nrf9160dk_nrf9160 and nrf9160dk_nrf52840?
f0644f2
to
7836eeb
Compare
Rebased on #32748. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm once unblocked.
Use devicetree instead of Kconfig to configure the board control switches in nRF9160 DK: - add binding for the switches that provide optional signal routings on this board - add binding for the GPIO interface that can be used for communication (e.g. UART based) between the nRF9160 and the nRF52840 on the DK, and add GPIO mapping for this interface so that its lines can be used without caring about of actual pin numbers on both sides - add binding for one GPIO line chosen from the above interface that is to allow the nRF9160 to reset the nRF52840 - update accordingly dts files and board specific code for both board definitions associated with the DK - introduce .dtsi files that can be included from dts overlays in order to facilitate the use of the above GPIO interface; modify the overlay in the hci_uart sample to provide an example of use of those files Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Use the multiple board revisions feature to provide support for the new hardware possibilities available in nRF9160 DK starting from v0.14.0. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Add devicetree node representing the PCAL6408A I2C-based I/O expander that is available in nRF9160 DK v0.14.0 or later. Provide also .dtsi files that can be used in applications to simplify switching to interfacing onboard LEDs and buttons through this expander instead of SoC pins. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
7836eeb
to
cbb0de3
Compare
Rebased after #32748 has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good.
Use devicetree instead of Kconfig to configure the board control switches in nRF9160 DK:
Use the multiple board revisions feature to provide support for the new hardware possibilities available in nRF9160 DK starting from v0.14.0.
Add DT node and .dtsi files that allow using the PCAL6408A I/O expander that is available in nRF9160 DK v0.14.0 or later to interface LEDs and buttons on the DK