scripts: kconfig: Fix uses of edt.compat2okay in helper functions #31926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if a given 'compat' is a key in edt.compat2okay before accessing its entry in dt_compat_on_bus() and dt_nodelabel_has_compat(), as for a non-existing key a new entry with an empty list would be created, and dt_compat_enabled() would then incorrectly return "y" when called for the same 'compat'. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
carlescufi
approved these changes
Feb 9, 2021
galak
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if a given 'compat' is a key in edt.compat2okay before accessing
its entry in dt_compat_on_bus() and dt_nodelabel_has_compat(), as for
a non-existing key a new entry with an empty list would be created,
and dt_compat_enabled() would then incorrectly return "y" when called
for the same 'compat'.
This issue currently causes CI for #31624 to fail (
CONFIG_GPIO_PCAL6408Agets incorrectly enabled here because of this check, and that results in the driver being compiled without any enabled instances of the corresponding hardware).