Fix alignment warnings in mcan #41265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes warnings by certain packed structs not being aligned to a 4 byte boundary. Fixes zephyrproject-rtos#41255 Signed-off-by: Pete Dietl <petedietl@gmail.com>
This commit fixes a strict aliasing rule violation by using a compiler builtin Signed-off-by: Pete Dietl <petedietl@gmail.com>
henrikbrixandersen
requested review from
henrikbrixandersen and
martinjaeger
henrikbrixandersen
added
the
Hotfix
|
@carlescufi Please review as you are the author of #40909. |
| for (uint32_t *ptr = (uint32_t *)msg_ram; | ||
| ptr < (uint32_t *)msg_ram + | ||
| for (uint32_t *ptr = (u32 *)msg_ram; | ||
| ptr < (u32 *)msg_ram + |
There was a problem hiding this comment.
Could this be fixed by #41273 instead of adding __may_alias?
There was a problem hiding this comment.
Yep. I commented in the pr you referring to.
There was a problem hiding this comment.
Yes, but you still reply on code that uses __may_alias, so it doesn't remove the usage.
|
Fixed by #41326. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.