drivers: can: m_can: fix alignmed issues #41326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderwachter
added
area: CAN
Hotfix
Member
Author
|
@pdietl Have made this hotfix. We can switch to your memcpy when it is through. |
alexanderwachter
force-pushed
the
can/fixMcanAlignment
branch
2 times, most recently
from
a5b3483 to
c3f8df2
Compare
alexanderwachter
force-pushed
the
can/fixMcanAlignment
branch
2 times, most recently
from
c91f7db to
9c70154
Compare
Make sure that all access to the msg_sram is 32 bit aligned. Signed-off-by: Alexander Wachter <alexander@wachter.cloud>
martinjaeger
approved these changes
Dec 20, 2021
Member
Author
|
The generic memcpy32 is not generic enough. I prefer a version with volatile qualifier so that the compiler is forced to copy 32bit in the order specified. |
Member
I'm also puzzled to have such function implemented in a driver. If |
Member
Author
|
@erwango this is a hotfix. As soon as we have something generic, we will switch to that instead. |
carlescufi
approved these changes
Dec 20, 2021
Member
|
I merged this to get the hotfix in, but I completely agree we need to move those functions out of the driver. |
This was referenced Dec 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that all access to the msg_sram is 32 bit aligned.
Fix for #41255 and #41074