-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[collab-hwm] Port GD32 to HWMv2 (ARM only) #67124
[collab-hwm] Port GD32 to HWMv2 (ARM only) #67124
Conversation
a95cfab
to
fb93dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SoC and board changes look good, not looked at python file
a98348c
to
c2b5dbc
Compare
b453cb7
to
9468661
Compare
Note: compliance failure is a false positive
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, wondering if the documentation include files could be generated automatically by aggregating the board.yaml
information and grouping by vendor there, but that's probably a small project in itself
Hi @gmarull , Not sure if compliance is a false positive here. |
It is, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ❤️
so should be added to the list here: zephyr/scripts/ci/check_compliance.py Lines 612 to 617 in 603c3af
|
boards/v2/arm/index.rst
Outdated
@@ -0,0 +1,10 @@ | |||
.. _boards-arm-holdings: | |||
|
|||
ARM Holdings Boards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARM Holdings Boards | |
Arm Holdings Boards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, but used "ARM Ltd." as in vendor-prefixes.txt
boards/v2/gigadevice/index.rst
Outdated
@@ -0,0 +1,10 @@ | |||
.. _boards-gigadevice: | |||
|
|||
Gigadevice Boards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it time we start looking at Sphinx/python tooling to automate some of the things around boards' documentation, in particular the generation of the toctree?
Reason I'm thinking this is that here you have GigaDevice spelled Gigadevice (lowercase d), and the boards' vendor is set as "GigaDevice Semiconductor". Looks like the kind of inconsistencies that, while certainly not the end of the world, can easily spread to many places.
If board.yml starts adopting the vendor prefix, a first step could be that we automatically add entries to substititions.txt
so that something like |vendor-gd|
gets replaced by the associated entry in vendor-prefixes.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kartben It would be nice to implement a new extension to display an interactive list of boards, where you can filter by vendor, soc, etc. It should now be easier with the new board.yml file. Regarding vendor, I think board.yml
should contain a vendor: $prefix
, and use a database (like we do for DT), cc: @tejlmand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think board.yml should contain a vendor: $prefix, and use a database (like we do for DT), cc: @tejlmand
Not against the idea, but we need to also remember that it should be easy for oot users to just create their own board.
Of course such users can provide a custom vendor-prefixes.txt file, but then it starts to require a bit more integration in multiple places.
I think we should have an enhancement issue, and then link that issue in here: #51831
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now: using text found in vendor-prefixes, so at least we're consistent everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest changes also looks good 👍
55331ba
to
c6028c7
Compare
Port all the Gigadevice SoCs to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Port the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Convert the board to HWMv2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Some SoC/board files have been moved, use new paths. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add an entry for Gigadevice boards. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add a new entry for ARM Holdings plc boards. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add a new entry for Renesas boards. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
SoC has been converted to v2. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
a5543dc
into
zephyrproject-rtos:collab-hwm
Note: RISC-V part skipped, it looks like RISC-V soc/ folder will need a bit of love first.
Contains commits from
#67147
#67355