STM32 nor flash controller gets address and size #68274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address and size are given by the DTS register property of the ospi nor. The size Property becomes useless Signed-off-by: Francois Ramu <francois.ramu@st.com>
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
Desvauxm-st,
GeorgeCGV,
Laczen,
de-nordic,
galak,
gautierg-st,
kartben and
nashif
erwango
reviewed
Jan 30, 2024
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Please also update migration guide doc/releases/migration-guide-3.6.rst
Contributor
Author
|
CI twister failure is due to #68284 |
Contributor
Author
|
updated : migration guide v3.6 |
Laczen
previously approved these changes
Jan 31, 2024
Contributor
Laczen
left a comment
Laczen
left a comment
There was a problem hiding this comment.
LGTM, it is nice to see the size removed.
Address and size are given by the DTS register property of the ospi nor : to be used by the ospi driver. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Define the reg and size property for the stm32u585 and stm32l562 disco kit. Refer to the dts/bindings/flash_controller/st,stm32-ospi-nor.yaml. The stm32l562 reads the sfdp table from the flash itself. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Address and size are given by the DTS register property of the qspi nor. The size Property becomes useless. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Address and size are given by the DTS register property of the qspi nor : to be used by the qspi driver. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Define the reg and size property for the stm32 boards with qspi inside Refer to the dts/bindings/flash_controller/st,stm32-ospi-nor.yaml. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Update the migration guide for release v3.6 to detail the change about the bindings of `st,stm32-ospi-nor` and `st,stm32-qspi-nor` compatible Signed-off-by: Francois Ramu <francois.ramu@st.com>
FRASTM
force-pushed
the
stm32_nor_size
branch
from
18c665c to
a9f4a93
Compare
Contributor
Author
|
same with DT_INST_REG_ADDR(0) and DT_INST_REG_ADDR_BY_IDX(0, 1) macro |
Laczen
approved these changes
Jan 31, 2024
de-nordic
approved these changes
Jan 31, 2024
Member
|
CI issue under fix in #68285 |
henrikbrixandersen
approved these changes
Feb 1, 2024
| } | ||
| #endif /* CONFIG_FLASH_PAGE_LAYOUT */ | ||
|
|
||
| LOG_INF("NOR octo-flash at 0x%lx (0x%x bytes)", |
Member
There was a problem hiding this comment.
Was this meant to use LOG_INF()?
Comment on lines
+1370
to
+1372
| LOG_INF("NOR quad-flash at 0x%lx (0x%x bytes)", | ||
| (long)(STM32_QSPI_BASE_ADDRESS), | ||
| dev_cfg->flash_size); |
Member
CI is sad |
Member
CI issue under fix in #68285 |
Contributor
Author
|
Contributor
|
I believe this PR has missed the board stm32h7b3i_dk https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/arm/stm32h7b3i_dk A search on boards for Show quite a few that missed an update. Search on |
11 tasks
This was referenced Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the stm32 qspi and ospi flash drivers can retrieve the NOR flash address and size directly from the device tree
of their
compatible = "st,stm32-qspi-nor";orcompatible = "st,stm32-ospi-nor";This is done with the property of the qspi-nor-flash or ospi-nor-flash node as follows:
That will make the nor-flash controller driver using the address and size property and will prepare the flash controller for the memory mapped mode (XIP).
That will avoid confusion around the expressed in bits or in byte : here is the reg second param a size in Bytes.