Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: Port NXP RT Family #69264

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

decsny
Copy link
Member

@decsny decsny commented Feb 20, 2024

No description provided.

soc/nxp/imxrt/soc.h Outdated Show resolved Hide resolved
drivers/memc/memc_mcux_flexspi.c Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt10xx/CMakeLists.txt Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt10xx/Kconfig.defconfig Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt10xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt11xx/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/nxp/mimxrt1160_evk/doc/index.rst Outdated Show resolved Hide resolved
boards/nxp/mimxrt1160_evk/doc/index.rst Outdated Show resolved Hide resolved
boards/nxp/mimxrt1170_evk/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/nxp/mimxrt1170_evk/Kconfig.mimxrt1170_evk Outdated Show resolved Hide resolved
boards/nxp/mimxrt1170_evk/board.cmake Outdated Show resolved Hide resolved
Copy link
Collaborator

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor nits.

Please check compliance.

As pointed out by @nordicjm then please consider if using board variant for "hyperflash" and "qspi" isn't more correct.

With hwmv2 we now support a more gerenal variant term.

soc/nxp/imxrt/Kconfig Outdated Show resolved Hide resolved
soc/nxp/imxrt/Kconfig Outdated Show resolved Hide resolved
soc/nxp/imxrt/Kconfig Outdated Show resolved Hide resolved
soc/nxp/imxrt/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt10xx/Kconfig Outdated Show resolved Hide resolved
@decsny decsny force-pushed the hwmv2_imxrt_ports branch 3 times, most recently from 26e64c1 to c128d00 Compare February 21, 2024 17:02
@decsny decsny force-pushed the hwmv2_imxrt_ports branch 2 times, most recently from 2298d76 to e4cd5ea Compare February 24, 2024 01:11
soc/nxp/imxrt/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt10xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt11xx/Kconfig Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt11xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt11xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt6xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/rt6xx/Kconfig.soc Outdated Show resolved Hide resolved
@decsny decsny force-pushed the hwmv2_imxrt_ports branch 4 times, most recently from 1d41034 to e10e8e6 Compare February 27, 2024 11:49
@zephyrbot zephyrbot removed manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Feb 27, 2024
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor nit.

soc/nxp/imxrt/imxrt11xx/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/imxrt/imxrt6xx/Kconfig.soc Outdated Show resolved Hide resolved
boards/nxp/mimxrt1160_evk/Kconfig.mimxrt1160_evk Outdated Show resolved Hide resolved
boards/nxp/mimxrt1170_evk/Kconfig.mimxrt1170_evk Outdated Show resolved Hide resolved
@danieldegrasse
Copy link
Collaborator

@decsny it looks like some of the RT1170 EVKB board files were missed in the rename:

$ find tests -name "mimxrt1170_evkb_cm7*"
tests/drivers/i2c/i2c_target_api/boards/mimxrt1170_evkb_cm7.overlay
tests/drivers/dma/loop_transfer/boards/mimxrt1170_evkb_cm7.overlay
tests/drivers/dma/loop_transfer/boards/mimxrt1170_evkb_cm7.conf
tests/drivers/mbox/mbox_data/boards/mimxrt1170_evkb_cm7.overlay
tests/drivers/mbox/mbox_data/boards/mimxrt1170_evkb_cm7.conf
tests/drivers/adc/adc_api/boards/mimxrt1170_evkb_cm7.overlay

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block


if FLASH_MCUX_FLEXSPI_XIP
# Avoid RWW hazards by defaulting logging to disabled
choice FLASH_LOG_LEVEL_CHOICE
	default FLASH_LOG_LEVEL_OFF
endchoice
choice MEMC_LOG_LEVEL_CHOICE
	default MEMC_LOG_LEVEL_OFF
endchoice
endif

Currently depends on SOC_SERIES_IMXRT10XX || SOC_SERIES_IMXRT11XX. It should only depend on SOC_FAMILY_NXP_IMXRT, this setting needs to be applied for all IMXRT SOCs

Port IMXRT family to HWMV2, including series:
- RT11XX
- RT10XX
- RT6XX

Not including RT5XX

Co-authored-by: Declan Snyder <declan.snyder@nxp.com>
Co-authored-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Co-authored-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Co-authored-by: David Leach <david.leach@nxp.com>
Co-authored-by: Yves Vandervennet <yves.vandervennet@nxp.com>
Co-authored-by: Emilio Benavente <emilio.benavente@nxp.com>

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Convert IMXRT boards except RT595

Co-authored-by: Declan Snyder <declan.snyder@nxp.com>
Co-authored-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
@nordicjm nordicjm merged commit dd7b98e into zephyrproject-rtos:collab-hwm Feb 28, 2024
28 checks passed
ubieda added a commit to ubieda/zephyr that referenced this pull request May 9, 2024
Instruction not getting compiled since zephyrproject-rtos#69264.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
ubieda added a commit to ubieda/zephyr that referenced this pull request May 9, 2024
Used multiple places in the tree. The idea is to determine if this node
corresponds to a specific node (e.g: flexspi) so that specific
configurations can get done. Without the fix, the macro expansions were
defaulting to false.

Instruction not getting compiled since zephyrproject-rtos#69264.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants