hwmv2: Port NXP iMX RT500 to HWMv2 #69269

danieldegrasse · 2024-02-21T00:35:37Z

This PR ports the RT500 SOC and RT595 EVK to HWMv2. This is a dual architecture SOC (Xtensa Fusion F1 and Arm Cortex M33). Therefore, this PR has been separated from the remainder of the iMX RT series ports, since it may require more detailed review.

Note- this PR Depends on #69264, and contains commits from it until it is merged

nordicjm · 2024-02-21T07:14:49Z

soc/nxp/imxrt/rt5xx/CMakeLists.txt

+# SPDX-License-Identifier: Apache-2.0
+#
+
+if (CONFIG_SOC_MIMXRT595S_CM33)


Suggested change

if (CONFIG_SOC_MIMXRT595S_CM33)

if(CONFIG_SOC_MIMXRT595S_CM33)

nordicjm · 2024-02-21T07:15:16Z

soc/nxp/imxrt/rt5xx/Kconfig

+ help
+ NXP RT5xx ADSP Series


help text for these should be in Kconfig.soc

nordicjm · 2024-02-21T07:15:59Z

soc/nxp/imxrt/rt5xx/Kconfig.defconfig

+config SOC_TOOLCHAIN_NAME
+ default "nxp_rt500_adsp"


Kconfig.soc

Moved. I am slightly unclear, what is the guidance for using Kconfig.defconfig versus Kconfig.soc in HWMv2? Is the idea that any Kconfig that is prefixed with "SOC_" should be in Kconfig.soc, or are there more general guidelines to follow?

Kconfig.defconfig is for overriding defaults in the zephyr tree, Kconfig.soc is just for SoC only Kconfigs that are needed by the build system (that means it only has the SoC Kconfig tree loaded, it does not have the rest of the zephyr Kconfig tree loaded)

nordicjm · 2024-02-21T07:16:25Z

soc/nxp/imxrt/rt5xx/Kconfig.soc

+ default "mimxrt595s_cm33" if SOC_MIMXRT595S_CM33
+ default "mimxrt595s_dsp" if SOC_MIMXRT595S_F1


default "mimxrt595s" if SOC_MIMXRT595S

nordicjm · 2024-02-21T07:17:11Z

boards/nxp/mimxrt595_evk/Kconfig

+ help
+ Board initialization priority.
+
+


Suggested change

nordicjm · 2024-02-21T07:17:50Z

boards/nxp/mimxrt595_evk/doc/index.rst

@@ -118,7 +118,7 @@ already supported, which can also be re-used on this mimxrt595_evk board:

 The default configuration can be found in the defconfig file:

- ``boards/arm/mimxrt595_evk/mimxrt595_evk_cm33_defconfig``
+ ``boards/arm/mimxrt595_evk/mimxrt595_evk_rt595_cm33_defconfig``


Link is wrong and should use zephyr_file e.g.

Suggested change

``boards/arm/mimxrt595_evk/mimxrt595_evk_rt595_cm33_defconfig``

:zephyr_file:`boards/nxp/mimxrt595_evk/mimxrt595_evk_rt595_cm33_defconfig`

nordicjm · 2024-02-21T07:18:20Z

boards/nxp/mimxrt595_evk/doc/index.rst

@@ -185,7 +185,7 @@ To build the hello_world sample for the RT500 DSP core:

 .. code-block:: shell

- $ west build -b nxp_adsp_rt595 samples/hello_world
+ $ west build -b mimxrt595_evk//f1 samples/hello_world


Use full board names and identifiers in all examples mimxrt595_evk/rt595/f1

Changed- I understand being verbose here, but where will we document the "short name" feature of using mimxrt595_evk//f1? I find this pretty useful, and want to make sure customers are aware of it.

It will be in the hwmv2 documentation

nordicjm · 2024-02-21T07:18:27Z

boards/nxp/mimxrt595_evk/doc/index.rst

@@ -249,7 +249,7 @@ Here is an example for the :ref:`hello_world` application. This example uses the

 .. zephyr-app-commands::
 :zephyr-app: samples/hello_world
- :board: mimxrt595_evk_cm33
+ :board: mimxrt595_evk//cm33


zephyrbot · 2024-02-23T17:38:31Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/nxp/imxrt/Kconfig.soc

soc/nxp/imxrt/rt10xx/Kconfig.soc

soc/nxp/imxrt/rt5xx/Kconfig.defconfig

nordicjm · 2024-02-26T08:03:47Z

soc/nxp/imxrt/rt5xx/Kconfig.soc

+ NXP RT5xx ADSP Series
+
+config SOC_SERIES
+ default "rt5xx" if SOC_SERIES_IMXRT_5XX


Suggested change

default "rt5xx" if SOC_SERIES_IMXRT_5XX

default "imxrt_5xx" if SOC_SERIES_IMXRT_5XX

Changed CONFIG_SOC_SERIES to imxrt5xx to align with rest of iMX RT series, and updated Kconfig name to SOC_SERIES_IMXRT5XX

nordicjm · 2024-02-26T08:03:57Z

soc/nxp/imxrt/rt5xx/Kconfig.soc

+config SOC_TOOLCHAIN_NAME
+ default "nxp_rt500_adsp"


default... if?

nordicjm · 2024-02-26T08:04:05Z

soc/nxp/imxrt/rt5xx/Kconfig.soc

+ bool
+
+config SOC_PART_NUMBER
+ string


Suggested change

string

nordicjm · 2024-02-28T07:29:27Z

Tests using old names need to be updated to use the new name

soc/nxp/imxrt/imxrt5xx/Kconfig.soc

danieldegrasse · 2024-02-28T14:39:15Z

Tests using old names need to be updated to use the new name

I believe all are, is there something I'm missing?

$ grep -rl "mimxrt595_evk_cm33" . --exclude-dir=".git"
./doc/releases/release-notes-3.3.rst

nordicjm · 2024-02-28T14:42:37Z

Compliance issue needs addressing. There was a test failure in the previous run

Convert NXP iMX RT5xx SOC to hardware model V2. This core is dual architecture, so both the ARM Cortex M33 and Xtensa Fusion F1 DSP have been unified within one SOC port folder. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Convert mimxrt595_evk to hardware model v2. Both the CM33 and Fusion F1 DSP devicetrees are moved to reside in the same board folder Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

danieldegrasse · 2024-02-28T14:44:36Z

Compliance issue needs addressing. There was a test failure in the previous run

Fixed now

danieldegrasse requested review from mmahadevan108 and dleach02 as code owners February 21, 2024 00:35

zephyrbot requested review from arnopo, avisconti, carlocaione, dbaluta, decsny, erwango, kartben, manuargue, MaureenHelm, nashif, teburd, tristan-google and yperess February 21, 2024 00:36

zephyrbot assigned kartben Feb 21, 2024

nordicjm requested changes Feb 21, 2024

View reviewed changes

nordicjm mentioned this pull request Feb 21, 2024

HWMv2 Board / SoC porting progress #67682

Closed

henrikbrixandersen changed the title ~~Port NXP iMX RT500 to HWMv2~~ hwmv2Port NXP iMX RT500 to HWMv2 Feb 21, 2024

henrikbrixandersen changed the title ~~hwmv2Port NXP iMX RT500 to HWMv2~~ hwmv2: Port NXP iMX RT500 to HWMv2 Feb 21, 2024

nordicjm force-pushed the collab-hwm branch from e354fda to dd510cd Compare February 23, 2024 13:53

danieldegrasse requested review from lorc, xakep-amatop, povergoing, firscity, sidcha, Navin-Sankar, aaillet, ABOSTM and FRASTM as code owners February 23, 2024 13:53

danieldegrasse requested review from greg-leach, LingaoM and soburi as code owners February 23, 2024 13:53

danieldegrasse force-pushed the feature/rt5xx-hwmv2 branch from 5db73b6 to fd4903f Compare February 23, 2024 17:37

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Feb 23, 2024

danieldegrasse force-pushed the feature/rt5xx-hwmv2 branch from fd4903f to b54e262 Compare February 23, 2024 17:50

nordicjm reviewed Feb 26, 2024

View reviewed changes

nordicjm added this to the v3.7.0 milestone Feb 27, 2024

danieldegrasse force-pushed the feature/rt5xx-hwmv2 branch from b54e262 to b34d496 Compare February 27, 2024 17:14

zephyrbot removed manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Feb 27, 2024

nordicjm approved these changes Feb 28, 2024

View reviewed changes

nordicjm requested changes Feb 28, 2024

View reviewed changes

soc/nxp/imxrt/imxrt5xx/Kconfig.soc Show resolved Hide resolved

dbaluta mentioned this pull request Feb 28, 2024

boards: Add support for the HiFi4 DSP of the MIMXRT685 #65229

Closed

carlescufi mentioned this pull request Feb 28, 2024

HW Model v2: Task list for merging collab-hwm back to main #69575

Closed

24 tasks

danieldegrasse force-pushed the feature/rt5xx-hwmv2 branch from b34d496 to e5014fe Compare February 28, 2024 14:38

danieldegrasse added 2 commits February 28, 2024 08:43

soc: nxp: rt5xx: convert RT5xx SOC to HWMv2

f5479e5

Convert NXP iMX RT5xx SOC to hardware model V2. This core is dual architecture, so both the ARM Cortex M33 and Xtensa Fusion F1 DSP have been unified within one SOC port folder. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

boards: nxp: convert mimxrt595_evk to hardware model v2

b7cf8f3

Convert mimxrt595_evk to hardware model v2. Both the CM33 and Fusion F1 DSP devicetrees are moved to reside in the same board folder Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

danieldegrasse force-pushed the feature/rt5xx-hwmv2 branch from e5014fe to b7cf8f3 Compare February 28, 2024 14:44

nordicjm approved these changes Feb 28, 2024

View reviewed changes

nordicjm merged commit 3309676 into zephyrproject-rtos:collab-hwm Feb 28, 2024
23 checks passed

danieldegrasse deleted the feature/rt5xx-hwmv2 branch February 28, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hwmv2: Port NXP iMX RT500 to HWMv2 #69269

hwmv2: Port NXP iMX RT500 to HWMv2 #69269

danieldegrasse commented Feb 21, 2024 •

edited

Loading

nordicjm Feb 21, 2024

nordicjm Feb 21, 2024

nordicjm Feb 21, 2024

danieldegrasse Feb 23, 2024

nordicjm Feb 26, 2024

nordicjm Feb 21, 2024

danieldegrasse Feb 23, 2024

nordicjm Feb 21, 2024

nordicjm Feb 21, 2024

nordicjm Feb 21, 2024

danieldegrasse Feb 23, 2024

nordicjm Feb 26, 2024

nordicjm Feb 21, 2024

zephyrbot commented Feb 23, 2024 •

edited

Loading

nordicjm Feb 26, 2024

danieldegrasse Feb 27, 2024

nordicjm Feb 26, 2024

nordicjm Feb 26, 2024

nordicjm commented Feb 28, 2024

danieldegrasse commented Feb 28, 2024

nordicjm commented Feb 28, 2024

danieldegrasse commented Feb 28, 2024

	if (CONFIG_SOC_MIMXRT595S_CM33)
	if(CONFIG_SOC_MIMXRT595S_CM33)

		default "mimxrt595s_cm33" if SOC_MIMXRT595S_CM33
		default "mimxrt595s_dsp" if SOC_MIMXRT595S_F1

	``boards/arm/mimxrt595_evk/mimxrt595_evk_rt595_cm33_defconfig``
	:zephyr_file:`boards/nxp/mimxrt595_evk/mimxrt595_evk_rt595_cm33_defconfig`

	default "rt5xx" if SOC_SERIES_IMXRT_5XX
	default "imxrt_5xx" if SOC_SERIES_IMXRT_5XX

hwmv2: Port NXP iMX RT500 to HWMv2 #69269

hwmv2: Port NXP iMX RT500 to HWMv2 #69269

Conversation

danieldegrasse commented Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephyrbot commented Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm commented Feb 28, 2024

danieldegrasse commented Feb 28, 2024

nordicjm commented Feb 28, 2024

danieldegrasse commented Feb 28, 2024

danieldegrasse commented Feb 21, 2024 •

edited

Loading

zephyrbot commented Feb 23, 2024 •

edited

Loading