STM32F7 SoC family and STM32F746G Discovery board basic support #7284

pic16f887 · 2018-05-01T17:13:19Z

I have closed pull request #7220 and created a new one. I had to drop previous PR because it was a mess which is hard to resolve to me (I am newbie in git and GitHub). Sorry for inconvenience.

codecov-io · 2018-05-01T17:40:30Z

Codecov Report

Merging #7284 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7284      +/-   ##
==========================================
- Coverage   64.61%   64.54%   -0.08%     
==========================================
  Files         421      420       -1     
  Lines       40296    40117     -179     
  Branches     6803     6762      -41     
==========================================
- Hits        26037    25892     -145     
+ Misses      11126    11108      -18     
+ Partials     3133     3117      -16

Impacted Files	Coverage Δ
boards/posix/native_posix/irq_handler.c	`80.24% <0%> (-4.64%)`	⬇️
subsys/net/ip/tcp.c	`55.24% <0%> (-3.58%)`	⬇️
kernel/queue.c	`82.4% <0%> (-2.55%)`	⬇️
subsys/net/ip/l2/ethernet/arp.c	`62.75% <0%> (-0.98%)`	⬇️
subsys/net/ip/dhcpv4.c	`5.72% <0%> (-0.29%)`	⬇️
kernel/sched.c	`81.17% <0%> (-0.24%)`	⬇️
subsys/net/ip/icmpv6.c	`34.72% <0%> (-0.13%)`	⬇️
subsys/net/ip/connection.c	`78.35% <0%> (-0.06%)`	⬇️
.../sched/schedule_api/src/test_priority_scheduling.c	`100% <0%> (ø)`	⬆️
include/drivers/bluetooth/hci_driver.h	`0% <0%> (ø)`	⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6f9b7...7c027e5. Read the comment docs.

dbkinder · 2018-05-01T18:20:30Z

boards/arm/stm32f746g_disco/doc/stm32f746g_disco.rst

+- DMA Controller
+
+More information about STM32F746NGH6 can be found here:
+       - `STM32F746NGH6 on www.st.com`_


Needs a blank line before the first list item. Also, don't indent, so should look like this:

More information about STM32F746NGH6 can be found here: - `STM32F746NGH6 on www.st.com`_ - `STM32F74xxx reference manual`_

dbkinder · 2018-05-01T18:21:23Z

boards/arm/stm32f746g_disco/doc/stm32f746g_disco.rst

+
+Other hardware features are not yet supported on Zephyr porting.
+
+The default configuration can be found in the defconfig file:


This renders better written as:

The default configuration can be found in the defconfig file: ``boards/arm/stm32f746g_disco/stm32f746g_disco_defconfig``

@dbkinder, I have fixed it.

dbkinder

One more edit, and you've got some problems reported by shippable: https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/14153/5/tests

dbkinder · 2018-05-01T20:52:03Z

boards/arm/stm32f746g_disco/doc/stm32f746g_disco.rst

+
+More information about STM32F746NGH6 can be found here:
+
+       - `STM32F746NGH6 on www.st.com`_


These two lines still need to be not indented...

Shippable prints warnings like this:
"B4 Second line is not empty". Does this mean that commit message body should have only one line?
Also there is one failed test, but I don't understand how check which exactly test was failed. Are these tests from sanity check?

ydamigos · 2018-05-02T06:19:13Z

Shippable prints warnings like this:
"B4 Second line is not empty". Does this mean that commit message body should have only one line?

@pic16f887 It means you need an empty line between commit message header and body.
The commit messages should follow the format:

Commit message header
--empty line--
Commit message body (multiple lines)
--empty line
Signed-off-by: ...

Please also check: http://docs.zephyrproject.org/1.9.0/contribute/contribute_guidelines.html#commit-guidelines

erwango

Additional remarks but it goes in good direction.

General points:

Add at least a one line comment in your commit messages, otherwise CI will fail
Enhance commit separation (lot of gpio, clock, uart related code ) in initial commit

Specific for Clock control:
You need to take car of the code under ifdef F4X in stm32_ll_clock.c, it is applicable to F7 as well.

erwango · 2018-05-02T13:37:24Z

arch/arm/soc/st_stm32/stm32f7/Kconfig.defconfig.stm32f746xg

+
+config NUM_IRQS
+	int
+	default 97


98 (when counting IRQ 0)

erwango · 2018-05-02T13:47:13Z

arch/arm/soc/st_stm32/stm32f7/flash_registers.h

+	} bit;
+};
+
+/* 3.8.7 Embedded flash registers */


erwango · 2018-05-02T13:47:34Z

arch/arm/soc/st_stm32/stm32f7/flash_registers.h

+ *
+ * Based on reference manual:
+ *
+ * Chapter 3.4: Embedded Flash Memory


erwango · 2018-05-02T13:53:25Z

arch/arm/soc/st_stm32/stm32f7/gpio_registers.h

+ */
+
+/* 6.4 GPIO registers - each GPIO port controls 16 pins */
+struct stm32f7x_gpio {


Please use exact names as mentioned in Reference manual:
moder, otyper, ospeedr, ....

In my opinion names like moder aren't human readable. I think it would better to left it like for STMF4 series or add ending reg, for example mode_reg.

I think that we should use naming rules that are not subjective, and then will not vary depending on the developer.
Hence, when possible, aligning on ref manual is the better option to me.

erwango · 2018-05-02T13:59:20Z

arch/arm/soc/st_stm32/stm32f7/soc.c

+	irq_unlock(key);
+
+	/* Update CMSIS SystemCoreClock variable (HCLK) */
+	/* At reset, system core clock is set to 25 MHz from HSI */


HSI is 16MHz

erwango · 2018-05-02T13:59:48Z

arch/arm/soc/st_stm32/stm32f7/soc.h

+#include <stm32f7xx_ll_bus.h>
+#include <stm32f7xx_ll_rcc.h>
+#include <stm32f7xx_ll_system.h>
+#include <stm32f7xx_ll_spi.h>


erwango · 2018-05-02T14:02:27Z

arch/arm/soc/st_stm32/stm32f7/dts.fixup

+
+#define CONFIG_NUM_IRQ_PRIO_BITS				ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS
+
+#define CONFIG_UART_STM32_PORT_1_BASE_ADDRESS	ST_STM32_USART_40011000_BASE_ADDRESS


Move these to the commit where you introduce serial driver

erwango · 2018-05-03T11:45:16Z

Seems we've lost some of your commits ..

pic16f887 · 2018-05-03T12:44:39Z

I dropped old commits. I attached only base STM32F7 commit. I will attach rest of updated commits soon.

pic16f887 · 2018-05-07T08:26:39Z

I committed updated code.

tagunil · 2018-05-07T12:56:46Z

@erwango, what is the policy for IRQ handlers for EXTI >= 16? F4 (and now F7) port enables them in stm32_exti_enable, other families do not. Which way should it be unified?

dbkinder

one more edit and we're good to go

dbkinder · 2018-05-07T22:11:08Z

boards/arm/stm32f746g_disco/doc/stm32f746g_disco.rst

+- On-board ST-LINK/V2-1 supporting USB re-enumeration capability
+- Five power supply options:
+
+    - ST LINK/V2-1


The sublist should be indented to the first character of the text of the parent list:

- Five power supply options: - ST LINK/V2-1

If you indent it too much, it changes the way the sublist is rendered.

I have fixed it and updated the commit.

dbkinder

Thanks!

pic16f887 · 2018-05-14T08:56:59Z

@erwango,
Could you please review my latest changes?

ydamigos · 2018-05-14T09:44:49Z

arch/arm/soc/st_stm32/stm32f7/soc.c

+ *        Tick interrupt priority is not used
+ * @return HAL status
+ */
+uint32_t HAL_GetTick(void)


Could you remove this function? It is now provided by arch/arm/soc/st_stm32/common/stm32cube_hal.c

erwango · 2018-06-13T11:24:27Z

@pic16f887, can you rebase on top of just merged #7997 ?

pic16f887 · 2018-06-13T18:50:59Z

@erwango
I have rebased the code.

aurel32 · 2018-06-13T22:56:34Z

drivers/interrupt_controller/exti_stm32.c

@@ -521,6 +559,59 @@ static void __stm32_exti_connect_irqs(struct device *dev)
 		CONFIG_EXTI_STM32_RTC_WKUP_IRQ_PRI,
 		__stm32_exti_isr_22, DEVICE_GET(exti_stm32),
 		0);
+#elif CONFIG_SOC_SERIES_STM32F7X


The shippable build failed due to this leftover from the rebase. Same issue a few lines below.

Thank you. I have update the code.

aurel32 · 2018-06-15T21:50:49Z

arch/arm/soc/st_stm32/stm32f7/Kconfig.defconfig.stm32f746xg

+config GPIO_STM32_PORTK
+	default y
+
+endif # GPIO_STM32


I just realized there is still a small rebase issue, there is a + before the endif.

Thank you. I have updated the code.

aurel32 · 2018-06-18T19:42:04Z

Hi @pic16f887, following the merge of #8359, this patchset needs yet another rebase :-(. In the patch serial: stm32: STM32F7 UART support, the part changing drivers/serial/uart_stm32.c should simply be dropped.

The patch includes support for STM32F746xG subfamily. Related to issue zephyrproject-rtos#6981. Signed-off-by: Yurii Hamann <yurii@hamann.site>

This patch adds clock control support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

Added flash memory support for STM32F7 family microcontrollers Signed-off-by: Yurii Hamann <yurii@hamann.site>

This patch adds GPIO support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

This patch adds pinmux header file for STM32F7 famlily microcontrollers Signed-off-by: Yurii Hamann <yurii@hamann.site>

The patch adds serial driver support for STM32F7 family microcontrollers, includes pinmux definitions and DTS fixup file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

This patch adds EXTI support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

This patch includes: STM32F7 family device tree file with basic and UART definitions. STM32F746 subfamily device tree file. Memory definitions for STM32F746xG subfamily. Signed-off-by: Yurii Hamann <yurii@hamann.site>

The patch contains basic code support, documentation, dts file and openocd configuration for STM32F746G discovery board. This patch related to the issue zephyrproject-rtos#6982. Signed-off-by: Yurii Hamann <yurii@hamann.site>

pic16f887 · 2018-06-19T06:35:44Z

Hi @aurel32,
I have rebased the code.

aurel32 · 2018-06-19T12:20:49Z

Hi @pic16f887. Thanks for the rebase, I have just checked, it's all good.

pic16f887 requested review from andrewboie, dbkinder and erwango as code owners May 1, 2018 17:13

dbkinder suggested changes May 1, 2018

View reviewed changes

pic16f887 force-pushed the master branch 6 times, most recently from 1c3b4b3 to ca60dac Compare May 1, 2018 19:00

dbkinder suggested changes May 1, 2018

View reviewed changes

pic16f887 force-pushed the master branch from a7cbbc9 to ca60dac Compare May 2, 2018 04:14

erwango requested changes May 2, 2018

View reviewed changes

pic16f887 closed this May 2, 2018

pic16f887 force-pushed the master branch from 163e78d to b2ca5ee Compare May 2, 2018 17:56

pic16f887 reopened this May 2, 2018

erwango added the platform: STM32 ST Micro STM32 label May 3, 2018

pic16f887 force-pushed the master branch 2 times, most recently from 13b1db7 to a164477 Compare May 4, 2018 05:00

dbkinder suggested changes May 7, 2018

View reviewed changes

pic16f887 force-pushed the master branch from a164477 to 9f8ffba Compare May 9, 2018 07:16

dbkinder approved these changes May 9, 2018

View reviewed changes

ydamigos reviewed May 14, 2018

View reviewed changes

erwango approved these changes Jun 12, 2018

View reviewed changes

pic16f887 force-pushed the master branch from 9b308fa to 43824d1 Compare June 13, 2018 18:42

This was referenced Jun 13, 2018

arm: core: cortex_m: add a barrier before the dummy FP instruction #8373

Merged

arm: core: cortex_m: wrongly assumes double precision FPU on Cortex-M7 #8374

Closed

aurel32 suggested changes Jun 13, 2018

View reviewed changes

pic16f887 force-pushed the master branch from 43824d1 to 533ff7e Compare June 14, 2018 06:26

aurel32 approved these changes Jun 14, 2018

View reviewed changes

aurel32 reviewed Jun 15, 2018

View reviewed changes

pic16f887 force-pushed the master branch from 533ff7e to 5bc578c Compare June 16, 2018 07:12

erwango approved these changes Jun 18, 2018

View reviewed changes

Yurii Hamann added 9 commits June 18, 2018 22:47

arch: arm: stm32: Basic STM32F7 family support

b192f94

The patch includes support for STM32F746xG subfamily. Related to issue zephyrproject-rtos#6981. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: clock_control: STM32F7 family clock control

cd29ee2

This patch adds clock control support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: flash: stm32: STM32F7 flash memory suport

8480701

Added flash memory support for STM32F7 family microcontrollers Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: gpio: stm32: STM32F7 GPIO support

fcb0cf1

This patch adds GPIO support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: pinmux: stm32: STM32F7 pinmux support

6eccb1f

This patch adds pinmux header file for STM32F7 famlily microcontrollers Signed-off-by: Yurii Hamann <yurii@hamann.site>

serial: stm32: STM32F7 UART support

2cb17f1

The patch adds serial driver support for STM32F7 family microcontrollers, includes pinmux definitions and DTS fixup file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: interrupt_controller: stm32: STM32F7 EXTI support

b7554b7

This patch adds EXTI support for STM32F7 family microcontrollers. Signed-off-by: Yurii Hamann <yurii@hamann.site>

arm: stm32: STM32F7 family device tree

787cee9

This patch includes: STM32F7 family device tree file with basic and UART definitions. STM32F746 subfamily device tree file. Memory definitions for STM32F746xG subfamily. Signed-off-by: Yurii Hamann <yurii@hamann.site>

boards: arm: stm32: Basic support for STM32F746G-DISCO board

7c027e5

The patch contains basic code support, documentation, dts file and openocd configuration for STM32F746G discovery board. This patch related to the issue zephyrproject-rtos#6982. Signed-off-by: Yurii Hamann <yurii@hamann.site>

pic16f887 force-pushed the master branch from 5bc578c to 7c027e5 Compare June 18, 2018 19:54

erwango approved these changes Jun 19, 2018

View reviewed changes

galak approved these changes Jun 28, 2018

View reviewed changes

galak merged commit e69c058 into zephyrproject-rtos:master Jun 28, 2018

aurel32 mentioned this pull request Jul 5, 2018

arch: arm: stm32: enable instruction and data caches on STM32F7 #8647

Merged

erwango mentioned this pull request Aug 8, 2018

Support for STM32 L1-series #9333

Closed


		Other hardware features are not yet supported on Zephyr porting.

		The default configuration can be found in the defconfig file:


		More information about STM32F746NGH6 can be found here:

		- `STM32F746NGH6 on www.st.com`_


		#define CONFIG_NUM_IRQ_PRIO_BITS ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

		#define CONFIG_UART_STM32_PORT_1_BASE_ADDRESS ST_STM32_USART_40011000_BASE_ADDRESS

STM32F7 SoC family and STM32F746G Discovery board basic support #7284

STM32F7 SoC family and STM32F746G Discovery board basic support #7284

Conversation

pic16f887 commented May 1, 2018

codecov-io commented May 1, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

dbkinder May 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ydamigos commented May 2, 2018

erwango left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pic16f887 May 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erwango commented May 3, 2018

pic16f887 commented May 3, 2018

pic16f887 commented May 7, 2018 • edited Loading

tagunil commented May 7, 2018

dbkinder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

pic16f887 commented May 14, 2018

Choose a reason for hiding this comment

erwango commented Jun 13, 2018

pic16f887 commented Jun 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aurel32 commented Jun 18, 2018

pic16f887 commented Jun 19, 2018

aurel32 commented Jun 19, 2018

codecov-io commented May 1, 2018 •

edited

Loading

dbkinder May 1, 2018 •

edited

Loading

pic16f887 May 2, 2018 •

edited

Loading

pic16f887 commented May 7, 2018 •

edited

Loading