Exclude native_posix for samples which set EVENTFD #73432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to kconfig dependencies, these samples set EVENTFD which depends on !NATIVE_APPLICATION, which results in a kconfig warning when it is forced to n, and therefore a twister build failure. As native_posix is a native_application, let's exclude it from the test to prevent this combination. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Due to kconfig dependencies, these samples set EVENTFD which depends on !NATIVE_APPLICATION, which results in a kconfig warning when it is forced to n, and therefore a twister build failure. As native_posix is a native_application, let's exclude it from the test to prevent this combination. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Due to kconfig dependencies, these samples set EVENTFD which depends on !NATIVE_APPLICATION, which results in a kconfig warning when it is forced to n, and therefore a twister build failure. As native_posix is a native_application, let's exclude it from the test to prevent this combination. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Due to kconfig dependencies, these samples set EVENTFD, POSIX_API, and others which depends on !NATIVE_APPLICATION, which results in kconfig warnings when they are forced to n, and therefore a twister build failure. As native_posix is a native_application, let's exclude it from the test to prevent this combination. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
added
the
Trivial
zephyrbot
added
area: Sockets
zephyrbot
requested review from
cfriedt,
kartben,
nashif,
ssharks,
tbursztyka and
ycsin
cfriedt
approved these changes
May 28, 2024
jukkar
approved these changes
May 29, 2024
Member
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
As it seems that native_posix usability is going down slowly (at least for networking), is there a plan to deprecate it?
Member
Author
Yes, in 4.0 |
ycsin
approved these changes
May 29, 2024
Member
|
This looks like a duplicate of #73256 |
Member
Author
|
Closing in favour of #73256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to kconfig dependencies, these samples set EVENTFD (and some also POSIX_API, and other options) which
depends on !NATIVE_APPLICATION, which when building for native_posix results in kconfig warnings when they
are forced to n, and therefore a twister build failure.
As native_posix is a native_application, let's exclude it from the test to prevent this combination from happening in CI.
Fixes #73434