drivers: i2s: stm32 sai add mclk-divider property #91404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: I2S
platform: STM32
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
anangl,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
kartben,
marwaiehm-st,
mathieuchopstm and
nashif
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
from
9c89e5f to
4afd8a5
Compare
mariopaja
changed the title
etienne-lms
previously approved these changes
Jun 12, 2025
erwango
reviewed
Jun 12, 2025
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
2 times, most recently
from
cf21f4c to
ec1b131
Compare
mariopaja
changed the title
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
from
ec1b131 to
41d0ef2
Compare
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
from
41d0ef2 to
38af4aa
Compare
|
Hi @erwango @etienne-lms, FYI, I have created a draft to add sai support to stm32h5 series #91555. |
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
from
38af4aa to
ccaa92e
Compare
erwango
reviewed
Jun 13, 2025
This property enables the user to configure the Master Clock Divider. Signed-off-by: Mario Paja <mariopaja@hotmail.com>
mariopaja
force-pushed
the
i2s_stm32_sai_frame_sync
branch
from
ccaa92e to
37265ce
Compare
erwango
approved these changes
Jun 13, 2025
|
There was a problem hiding this comment.
I think this change requires a note to be added in the migration guide? @erwango
| .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(index), \ | ||
| .mclk_enable = DT_INST_PROP(index, mclk_enable), \ | ||
| .mclk_div_enable = DT_INST_PROP(index, mclk_div_enable), \ | ||
| .mclk_div = (enum mclk_divider)DT_ENUM_IDX(DT_DRV_INST(index), mclk_divider), \ |
There was a problem hiding this comment.
Nit: instead of the unstable DT_ENUM_IDX, something more stable like this could be used:
Suggested change
| .mclk_div = (enum mclk_divider)DT_ENUM_IDX(DT_DRV_INST(index), mclk_divider), \ | |
| .mclk_div = CONCAT(MCLK_, DT_INST_STRING_UPPER_TOKEN(index, mclk_divider)), \ |
| hsai->Init.NoDivider = SAI_MASTERDIVIDER_DISABLED; | ||
| } else { | ||
| hsai->Init.NoDivider = SAI_MASTERDIVIDER_ENABLE; | ||
| if (cfg->mclk_div == (enum mclk_divider)MCLK_DIV_256) { |
There was a problem hiding this comment.
Nit: cast should not be needed?
Suggested change
| if (cfg->mclk_div == (enum mclk_divider)MCLK_DIV_256) { | |
| if (cfg->mclk_div == MCLK_DIV_256) { |
| if (cfg->mclk_div_enable) { | ||
| hsai->Init.NoDivider = SAI_MASTERDIVIDER_ENABLE; | ||
| } else { | ||
| if (cfg->mclk_div == (enum mclk_divider)MCLK_NO_DIV) { |
There was a problem hiding this comment.
Nit: cast should not be needed?
Suggested change
| if (cfg->mclk_div == (enum mclk_divider)MCLK_NO_DIV) { | |
| if (cfg->mclk_div == MCLK_NO_DIV) { |
Not required. SAI was introduced in current release. |
mathieuchopstm
approved these changes
Jun 20, 2025
|
@mathieuchopstm I can make the changes only starting from next week. If it doesn't get merged I can implement your suggestions immediately then. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property enables the user to configure the Master Clock Divider
The property sets nodiv or osr value
MCKDIV[5:0] = SAI_CK_x / (FS * (FRL + 1))
MCKDIV[5:0] = SAI_CK_x / (FS * (OSR + 1) * 256)