-
Notifications
You must be signed in to change notification settings - Fork 8.1k
drivers: i2s: add sai support for stm32h5xx #91555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requests otherwise LGTM
| reg = <0x40015424 0x20>; | ||
| clocks = <&rcc STM32_CLOCK(APB2, 21U)>, | ||
| <&rcc STM32_SRC_PLL2_P SAI1_SEL(0)>; | ||
| dmas = <&gpdma1 0 54 0>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use defines instead of magic numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erwango,
I have used 0 here because the DMA defines are not used at all in the driver. It will have no effect configuring the DMA.
I will open another PR after merging H5xx to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe fix the commit message:
-This PR enable SAI on STM32H5 series
+Define SAI nodes for STM32H5 series and enable samples/drivers/i2s/output
+for nucleo_h563zi board.Define SAI nodes for STM32H5 series and enable samples/drivers/i2s/output for nucleo_h563zi board. Signed-off-by: Mario Paja <mariopaja@hotmail.com>
|



This PR enable SAI on STM32H5 series.
Tested with nucleo_h563zi:
STM32H5 Audio Sample: 44.1KHz, 16bit, 2CH, PCM5102A DAC
stm32h5xx.mp4