Skip to content

Conversation

@mariopaja
Copy link
Contributor

@mariopaja mariopaja commented Jun 13, 2025

This PR enable SAI on STM32H5 series.
Tested with nucleo_h563zi:

stm32h5xx_sai

STM32H5 Audio Sample: 44.1KHz, 16bit, 2CH, PCM5102A DAC

stm32h5xx.mp4

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests otherwise LGTM

reg = <0x40015424 0x20>;
clocks = <&rcc STM32_CLOCK(APB2, 21U)>,
<&rcc STM32_SRC_PLL2_P SAI1_SEL(0)>;
dmas = <&gpdma1 0 54 0>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use defines instead of magic numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erwango,
I have used 0 here because the DMA defines are not used at all in the driver. It will have no effect configuring the DMA.

I will open another PR after merging H5xx to address this.

@erwango erwango added this to the v4.2.0 milestone Jun 26, 2025
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe fix the commit message:

-This PR enable SAI on STM32H5 series
+Define SAI nodes for STM32H5 series and enable samples/drivers/i2s/output
+for nucleo_h563zi board.

Define SAI nodes for STM32H5 series and enable samples/drivers/i2s/output
for nucleo_h563zi board.

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@sonarqubecloud
Copy link

@dkalowsk dkalowsk removed this from the v4.2.0 milestone Jun 30, 2025
@dkalowsk dkalowsk added this to the v4.3.0 milestone Jun 30, 2025
@aescolar aescolar merged commit 442465f into zephyrproject-rtos:main Jul 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants