scripts: valgrind: suppress missing clean-up in nct_new_thread() #95229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpambor
approved these changes
Aug 31, 2025
There was a problem hiding this comment.
LGTM. I am wondering if this could be combined with the entry for posix_new_thread which only calls nct_new_thread.
zephyr/arch/posix/core/posix_core_nsi.c
Lines 46 to 49 in 04dfa77
aescolar
reviewed
Sep 1, 2025
Suppress memory leaks detected by valgrind originating from nct_new_thread(), part of the native_sim CPU thread emulation. This covers calls to posix_new_thread() as well, since this function simply calls nct_new_thread (but may be optimized out by the compiler). Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
henrikbrixandersen
force-pushed
the
valgrind_supress_nct_new_thread_no_cleanup
branch
from
c2ac928 to
ebfe8ee
Compare
|
tpambor
approved these changes
Sep 1, 2025
aescolar
approved these changes
Sep 1, 2025
fabiobaltieri
approved these changes
Sep 1, 2025
henrikbrixandersen
deleted the
valgrind_supress_nct_new_thread_no_cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress memory leaks detected by valgrind originating from nct_new_thread(), part of the native_sim CPU thread emulation.
This covers calls to posix_new_thread() as well, since this function simply calls nct_new_thread (but may be optimized out by the compiler).
Inspired to use valgrind with native_sim by @aescolar's great talk on native_sim at ZDS 2025 in Amsterdam, thanks!