Skip to content

Conversation

tpambor
Copy link
Contributor

@tpambor tpambor commented Oct 8, 2025

Add tpambor as collaborator to Native_sim and POSIX arch area.

Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
Copy link

sonarqubecloud bot commented Oct 8, 2025

@kartben
Copy link
Contributor

kartben commented Oct 10, 2025

@aescolar unless the bot did something clearly wrong, which it didn't here, please don't re-assign :)

@kartben kartben assigned MaureenHelm and nashif and unassigned aescolar Oct 10, 2025
@aescolar
Copy link
Member

@aescolar unless the bot did something clearly wrong, which it didn't here, please don't re-assign :)

@kartben
To document why I did that change:
Note that as per our process the gate to accept a contributor as new collaborator in an area is the area maintainer approval (in this case me).
Our merge criteria automation is based on the assignee approval + 1 extra person.
As such the logical thing would be to have those match or at least have that gate be ensured.

The current automation on PR assignment of the MAINTAINER file is just based on a mini area which includes (the whole) MAINTAINER file.

This is one of those cases where our assignee and merge criteria automation errs by being too simple.

Note that as maintainer or the affected area and release engineer I do have the right/responsibility to correct this when necessary.
And as such I corrected it.
Once I have approved it, I considered switching the assignee back to either/both @nashif and @MaureenHelm to ensure either of them as MAINTAINER file maintainer would also gate the merge, but a) I did not expect @MaureenHelm, @nashif or @stephanosio to object to this change, and b) in this case this is a contributor added as collaborator which, by our process, does not require TSC approval and therefore it seemed unnecessary to gate it by the current (or previous) TSC chair approval.

@cfriedt cfriedt merged commit cbb9889 into zephyrproject-rtos:main Oct 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants