Bluetooth: Host: Add legacy pairing test config #99742
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
PavelVPV,
Thalley,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen and
sjanc
|
|
||
| config BT_SMP_ENFORCE_LEGACY_PAIRING | ||
| bool "Enforce legacy pairing" | ||
| depends on BT_TESTING |
There was a problem hiding this comment.
Is it not allowed to only support legacy pairing in recent version of the core spec?
There was a problem hiding this comment.
It's allowed, but since Zephyr 3.0 the use of legacy pairing has been discouraged for being less/not secure, so I didn't want this Kconfig to imply otherwise. Zephyr-devices support legacy pairing with devices that do not support secure connections, but since Zephyr-devices do support it they will always default to this (and thus this config is needed to force it).
There was a problem hiding this comment.
I'm wondering if we should allow setting this without BT_TESTING, but treat it as a warning for the above reasons. That would be similar to how we treat e.g. BT_USE_DEBUG_KEYS, where we have both Kconfig and CMake warnings if it's enabled.
Alternatively we should consider adding the same depends on BT_TESTING for things like BT_USE_DEBUG_KEYS.
There was a problem hiding this comment.
Both suggestions are fine by me, do you have any thoughts @jhedberg?
Adds the `CONFIG_BT_SMP_LEGACY_PAIR_ONLY` Kconfig option to force devices to use legacy pairing. This has a dependency on `CONFIG_BT_TESTING` as it is only intended for testing purposes, and use of legacy pairing is discouraged. Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
HaavardRei
force-pushed
the
legacy_pairing_test_config
branch
from
dba8951 to
ce2bf26
Compare
|
5 participants
Adds the
CONFIG_BT_SMP_LEGACY_PAIR_ONLYKconfig option to force devices to use legacy pairing. This has a dependency onCONFIG_BT_TESTINGas it is only intended for testing purposes, and use of legacy pairing is discouraged.