Skip to content

Conversation

rlisowski-maystreet
Copy link
Contributor

@rlisowski-maystreet rlisowski-maystreet commented Sep 9, 2022

At the moment empty arrays and objects are not rendered. This can cause errors, when copying the json and trying to use it somewhere else.

  • added code to render valid brackets
  • updated App.svelte test1 json to include empty object, array, string, null and undefined. Those were added to the top and the nth level of json.

current main:
Screenshot 2022-09-09 at 10 54 46
fix branch:
Screenshot 2022-09-09 at 11 02 06

@rlisowski-maystreet rlisowski-maystreet force-pushed the rlisowski-maystreet/fix_rendering_for_blank branch from b3d9de2 to 44a4439 Compare September 9, 2022 10:02
@rlisowski-maystreet rlisowski-maystreet changed the title Fix rendering for empty array and empty objects Fix rendering for empty arrays and empty objects Sep 9, 2022
@zerodevx
Copy link
Owner

zerodevx commented Sep 9, 2022

That's a good catch! Could you kindly remove package-lock.json from your commit before I merge? Thanks!

@rlisowski-maystreet
Copy link
Contributor Author

updated

@zerodevx zerodevx merged commit a2ce33e into zerodevx:main Sep 9, 2022
@zerodevx
Copy link
Owner

zerodevx commented Sep 9, 2022

Thanks for your contribution 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants