Skip to content

Fix rendering for empty arrays and empty objects #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix rendering for empty arrays and empty objects #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44a4439
Fix rendering for empty array and empty objects
radlis Sep 9, 2022
a1475b4
Remove package-lock.json changes
radlis Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions docs/App.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,17 @@ const test1 = [
longitude: -0.093647,
tags: ['quis', 'officia', 'ullamco', 'occaecat', 'sint', 'pariatur', 'fugiat'],
friends: [
{ id: 0, name: 'Thelma Robles' },
{ id: 1, name: 'Genevieve Russo' },
{ id: 2, name: 'Mcclure Tate' }
{ id: 0, name: 'Thelma Robles', address: [] },
{ id: 1, name: 'Genevieve Russo', address: {} },
{ id: 2, name: 'Mcclure Tate', address: null }
],
greeting: 'Hello, Hampton Hardin! You have 2 unread messages.',
favoriteFruit: 'banana'
favoriteFruit: 'banana',
contacts: [],
report: {},
email2: null,
email3: '',
email4: undefined
},
{
_id: '60702426f2aec6774924fd63',
Expand Down
6 changes: 5 additions & 1 deletion src/JsonView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ const clicked = () => {
}
</script>

{#if items.length}
{#if !items.length}
<span class="bracket" tabindex="0">{openBracket}{closeBracket}</span>{#if !_last}<span
class="comma">,</span
>{/if}
{:else}
<span class:hidden={collapsed}>
<span class="bracket" on:click={clicked} tabindex="0">{openBracket}</span>
<ul>
Expand Down