Refactor protocol literals into constants #3847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protcol string for PGM, EPGM and NORM is still represented in literal strings.
While changing literals into constants, I also applied conditional compile for them.
Some code blocks didn't covered with conditional compile, and the others is using both PGM and NORM.
I tried to change those code blocks as simple as possible, but some code blocks seems messy.
I want someone review and comment especially for following code blocks. (I've marked WiP just for review)
Code block1
Code block2
Code block3