Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor protocol literals into constants #3847

Merged
merged 3 commits into from
Mar 14, 2020
Merged

Refactor protocol literals into constants #3847

merged 3 commits into from
Mar 14, 2020

Commits on Mar 14, 2020

  1. Problem: literals protocol names still remains 

    Solution: replace into named constants
    @JSYoo5B
    JSYoo5B committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    ebd22ec View commit details
    Browse the repository at this point in the history

  2. Problem: some conditional compile was not applied 

    Conditinoal compile for OPENPGM and NORM is mixed.
Also found few codes which needs conditional compile but not applied.

Solution: Apply conditional compile preprocessors
    @JSYoo5B
    JSYoo5B committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    4f436ce View commit details
    Browse the repository at this point in the history

  3. Problem: some cond. compile may cause problem 

    Some ifdefs in condition checking may cause problem in some compiler or
static analyzers. When PGM and NORM both are disabled, some condition
will be derived as false || false.

Solution: Splitted condition checking for every ifdef conditions
    @JSYoo5B
    JSYoo5B committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    38fd1fd View commit details
    Browse the repository at this point in the history