Stop bundling libzmq with IPC support on Windows #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to bugs that cause crashes that can't be worked around wait for at least 4.3.5 before re-enabling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to bugs in libzmq's detection of AF_UNIX that cause crashes that can't be worked around (zeromq/libzmq#4422)
I don't love this since it's removing a feature from wheels. Building pyzmq from source should still get the same result for folks who want IPC. The alternative was to require users experiencing a crash to build from source, which I think is worse than missing a little-used feature with a buggy implementation that crashes users who don't even try to use the feature.
Need to wait for at least 4.3.5 before re-enabling 142 builds with IPC support
Should fix #1505