disable IPC in Windows wheels (again) #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this may be the same crash that caused us to disable it in 24.
minrk
force-pushed
the
rm-windows-epoll
branch
from
e410df8
to
d4ee89d
Compare
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this may be the same crash that caused us to disable it in #1758. It was reintroduced in pyzmq 26 due to the new build system and libzmq 4.3.5 appears to not have fixed the error.
It is my hope that this will fix #1981, which I suspect was caused by re-enabling IPC. Maybe someday the upstream bug in libzmq can be understood and fixed.
update: I've confirmed this fixes at least one Windows system with no other practical workaround, which is enough for me.
closes #1999
closes #1981
closes #1505