Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade styled component to v6 #705

Merged
merged 10 commits into from
Dec 23, 2024

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Nov 18, 2024

Add $prefix on custom props of styled components.
Remove or replace invalid styles.
Remove types.d.ts declaration file, which was messing types.
Update tsconfig to allow js.
Update types which were messed up by the declaration file, to reflect the real type.
Migrate some js file to ts.
Add some FIXME comment where the types are too messed up, and additional knowledge/refactor is required to fix them.

Refs: CO-1608


@beawar beawar marked this pull request as ready for review November 22, 2024 09:11
@beawar beawar requested a review from a team as a code owner November 22, 2024 09:11
matteobaglini
matteobaglini previously approved these changes Dec 19, 2024
@gnekoz gnekoz marked this pull request as draft December 19, 2024 15:56
@gnekoz gnekoz marked this pull request as ready for review December 19, 2024 16:07
Copy link

Failed Quality Gate failed

  • 55.40% Coverage on New Code (is less than 80.00%)
  • 2 New Issues (is greater than 0)

Project ID: carbonio-mails-ui

View in SonarQube

@matteobaglini matteobaglini merged commit 2a037ae into devel Dec 23, 2024
2 of 3 checks passed
@matteobaglini matteobaglini deleted the CO-1608-upgrade-styled-components-to-v6 branch December 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants