Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade styled-components to v6 #502

Conversation

rodleyorosa
Copy link
Contributor

  • add $ prefixes
  • update styled-components package
  • remove SimpleInterpolation type with specific return types

Refs: SHELL-107

@rodleyorosa rodleyorosa self-assigned this Sep 5, 2024
rodleyorosa and others added 3 commits September 5, 2024 08:38
Refs: SHELL-107
…-when-container-queries-feat-will-be-available-in-styled-components
src/shell/boards/board-container.tsx Outdated Show resolved Hide resolved
src/shell/boards/board-tab.tsx Outdated Show resolved Hide resolved
src/shell/boards/board.tsx Outdated Show resolved Hide resolved
rodleyorosa and others added 6 commits September 30, 2024 09:39
Refs: SHELL-107
Co-authored-by: Beatrice Guerra <beatrice.guerra@zextras.com>
…ner-queries-feat-will-be-available-in-styled-components' of github.com:zextras/carbonio-shell-ui into SHELL-107-Remove-css-with-container-queries-when-container-queries-feat-will-be-available-in-styled-components
Refs: SHELL-107
…container-queries-when-container-queries-feat-will-be-available-in-styled-components
…-when-container-queries-feat-will-be-available-in-styled-components
@rodleyorosa rodleyorosa changed the title refactor: remove css with styled components container queries feat: upgrade styled-components to v6 Oct 3, 2024
…-with-container-queries-when-container-queries-feat-will-be-available-in-styled-components
…-with-container-queries-when-container-queries-feat-will-be-available-in-styled-components

This comment has been minimized.

lisaparma
lisaparma previously approved these changes Nov 13, 2024
…-with-container-queries-when-container-queries-feat-will-be-available-in-styled-components

This comment has been minimized.

This comment has been minimized.

@beawar
Copy link
Contributor

beawar commented Nov 21, 2024

I think we have finally reached a good point on all involved projects. The PR can be considered stable and reviewable.

…-when-container-queries-feat-will-be-available-in-styled-components
Copy link

Failed

  • 61.70% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 61.70% Coverage (66.40% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit 2e392ef into devel Nov 27, 2024
2 of 3 checks passed
@beawar beawar deleted the SHELL-107-Remove-css-with-container-queries-when-container-queries-feat-will-be-available-in-styled-components branch November 27, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants