Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with zf1-future #25

Open
glensc opened this issue Aug 26, 2020 · 9 comments
Open

Merge with zf1-future #25

glensc opened this issue Aug 26, 2020 · 9 comments

Comments

@glensc
Copy link
Contributor

glensc commented Aug 26, 2020

Merge efforts with shardj/zf1-future project:

Seems they have gone further original plan to support modern PHP: Minimum version required is PHP 7.4.

Also, it lacks package splitting, which I love in zf1s.

So the project goals are not the same, but there may be large overlapping efforts.

x-ref:

@glensc
Copy link
Contributor Author

glensc commented Aug 26, 2020

They were thinking restoring backward compat from 7.0:

but seems now their minimum is 7.4 instead...

@Shardj
Copy link
Contributor

Shardj commented Sep 18, 2020

It should still be 7.0 minimum, I don't think 7.4 has ever been the minimum. If it was I'd be pretty screwed since all of my systems were on 7.2 until this morning

@Shardj
Copy link
Contributor

Shardj commented Sep 11, 2021

Lots of respect for the amount of work you do for zf1s and the help you provide to zf1-future @glensc

@glensc
Copy link
Contributor Author

glensc commented Oct 11, 2022

Some unknown files committed in (origin and author unclear):

@glensc
Copy link
Contributor Author

glensc commented Oct 11, 2022

@falkenhawk I was trying to cherry-pick some PHP 8.1 changes from zf1-future, and it seemed need to cherry-pick some earlier changes, so ended up picking:

it seemed like a good change, and harmless (just phpdoc changes), but it already assumes some preceding changes being applied:

shall I continue? as they already discussed there the exact thing, it makes code diverged a lot, after these two the differences should be smaller. indeed picking 104 may introduce another (larger) pull request to apply.

@sreichel
Copy link

shall I continue?

Please.

@glensc
Copy link
Contributor Author

glensc commented Jan 18, 2023

shall I continue?

Please.

Maintainers here rejected picking up formatting changes from zf1-future, so that was declined:

@sreichel
Copy link

To bad. It would be really nice to have it synced with zf1-future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants