Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zend-db] Fix PHPDoc @return statement for Zend_Db_Select::query() #95

Merged
merged 1 commit into from
Sep 10, 2021
Merged

[zend-db] Fix PHPDoc @return statement for Zend_Db_Select::query() #95

merged 1 commit into from
Sep 10, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 10, 2021

@rruchte @glensc
Fixes PHPDoc @return statement for Zend_Db_Select::query() "PDO_State…
f5976ea 
…ment" has been included in the PHPDoc since pre-1.0 days, but has never been correct. This function will only ever return instances of Zend_Db_Statement.

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@glensc glensc mentioned this pull request Sep 10, 2021
Open
@glensc glensc changed the title Fix PHPDoc @return statement for Zend_Db_Select::query() [zend-db] Fix PHPDoc @return statement for Zend_Db_Select::query() Sep 10, 2021
falkenhawk
falkenhawk approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@falkenhawk falkenhawk merged commit 7bde0f9 into zf1s:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glensc @falkenhawk @rruchte