[zend-validate] Adding croatian diacritical characters to hostname validation #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
changed the title
|
Maybe we should add the whole list instead of picking just croatian variant? 🤔 |
|
@falkenhawk i just wanted to sync the changes in the other repo. as the sync is not complete the picture is fuzzy. i suggest to release 1.14.0 first before any of these new pull requests. |
|
1.14.0 is released, so that is no longer a blocker |
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
falkenhawk
force-pushed
the
zf1-future-160
branch
from
5562528 to
1ac21bc
Compare
falkenhawk
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry Shardj/zf1-future#160
cc @kiboke