Adding a new function to create BRKOUT_CFG TABLE in config db #17

samaity · 2019-12-11T03:15:08Z

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

- What I did
BREAKOUT_CFG Table will be generated in config db if platform.json is available.
.
- How I did it
Added a new Function get_breakout_mode function in portconfig file and using this function in sonic-cfggen, "BREAKOUT_CFG" get generated.

so, if platform.json is available in the device, "BREAKOUT_CFG" table will be generated. Otherwise, it will not be generated and will work as of today.

refractored breakout Cli PR has a dependency on this PR.

- How to verify it

with platform.json presence

samaity@server09:~/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests/breakout$ sudo pytest -s -v --dvsname=vs-sang test_breakout_cli.py
=================================================================== test session starts ====================================================================
platform linux2 -- Python 2.7.15+, pytest-3.3.0, py-1.8.0, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /home/samaity/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests/breakout, inifile:
collected 2 items

test_breakout_cli.py::TestBreakoutCli::test_InitialBreakoutMode remove extra link dummy
PASSED                                                                               [ 50%]
test_breakout_cli.py::TestBreakoutCli::test_breakout_modes **** Breakout Cli test Starts ****
**** 1X100G --> 2x50G passed ****
**** 2x50G --> 1x100G[40G] passed ****
**** 1X100G --> 4x25G[10G] passed ****
**** 4x25G[10G] --> 1x100G[40G] passed ****
**** 1X100G --> 2x50G mode change ****
**** 2X50G --> 4x25G[10G] passed ****
**** 4x25G[10G] --> 2X50G passed ****
**** 2x50G  -- > 1X100G mode change ****
**** 1x100G[40G] --> 2x25G(2)+1x50G(2) passed ****
**** 2x25G(2)+1x50G(2) --> 1x100G[40G] passed ****
**** 1x100G[40G] --> 1x50G(2)+2x25G(2)  passed ****
**** 1x50G(2)+2x25G(2) --> 1x100G[40G] passed ****
**** 1x100G[40G] --> 2x50G  mode change ****
**** 2x50G --> 2x25G(2)+1x50G(2)  passed ****
**** 1x50G(2)+2x25G(2) --> 2x25G(2)+1x50G(2)  passed ****
**** 2x25G(2)+1x50G(2)  --> 1x100G[40G]  passed ****
PASSED                                                                                    [100%]

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

src/sonic-config-engine/portconfig.py

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

* Adding a new function to create BRKOUT_CFG TABLE in config db Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> * Speed fix and portconfig file check Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> * Minor update for speed Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

* src/sonic-telemetry fa8d498...3bd7ca3 (4): > Update gnmi deps (zhenggen-xu#40) > [testdata] Update SFP keys to align with new standard (zhenggen-xu#39) > Fixed the parameters for subscribe APIs (zhenggen-xu#38) > Azure ro mode (zhenggen-xu#34) * src/sonic-mgmt-common 444aa9a...cc01ce4 (4): > Make gnmi dep version the same as in telemetry repo (zhenggen-xu#17) > Cleanup translib and cvl go test cases (zhenggen-xu#13) > Package update and enhancements/fixes in YGOT, and Request Binder (zhenggen-xu#12) > Translib phase I changes (zhenggen-xu#11) Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (zhenggen-xu#18) > Filter out non-printable characters read from syseeprom (zhenggen-xu#17)

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> * Added BFN PSU cache (zhenggen-xu#9) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fans and Fantray platform APIs update (zhenggen-xu#7) * [BFN] Updated SFP platform APIs (zhenggen-xu#10) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [BFN] Updated platform API for thermal (zhenggen-xu#8) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "[BFN] Fans and Fantray platform APIs update (zhenggen-xu#7)" (zhenggen-xu#11) This reverts commit c62a733. * Add support health monitor system (zhenggen-xu#15) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (zhenggen-xu#14) * Fix fix_alignment (zhenggen-xu#17) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Improvement show environment (zhenggen-xu#16) * Added PSU temperature skip into platform.json (zhenggen-xu#18) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] fix fan status from Not OK to Ok (zhenggen-xu#19) * [BFN] Updated SFP platform plugin (zhenggen-xu#13) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (zhenggen-xu#21) Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com> * [barefoot] Tmp fix vendor_rev (zhenggen-xu#22) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [Newport] Thermal manager (zhenggen-xu#23) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (zhenggen-xu#30) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com> Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com> Co-authored-by: Petro Bratash <petrox.bratash@intel.com> Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

[sonic-linkmgrd][master] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (zhenggen-xu#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (zhenggen-xu#14) sign-off: Jing Zhang zhangjing@microsoft.com

[sonic-linkmgrd][202012] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (zhenggen-xu#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (zhenggen-xu#14) sign-off: Jing Zhang zhangjing@microsoft.com

Adding a new function to create BRKOUT_CFG TABLE in config db

2051f41

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity requested review from zhenggen-xu and vasant17 December 11, 2019 03:15

zhenggen-xu approved these changes Dec 11, 2019

View reviewed changes

samaity mentioned this pull request Dec 12, 2019

DPB Breakout Cli Test with proper setup #18

Merged

Speed fix and portconfig file check

e87b26c

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity force-pushed the breakout_cfg_create branch from 96abac6 to e87b26c Compare December 13, 2019 18:27

zhenggen-xu reviewed Dec 13, 2019

View reviewed changes

src/sonic-config-engine/portconfig.py Outdated Show resolved Hide resolved

Minor update for speed

b171d65

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

zhenggen-xu approved these changes Dec 13, 2019

View reviewed changes

zhenggen-xu merged commit f071cf7 into zhenggen-xu:sonic-cfg-mgmt Dec 13, 2019

samaity deleted the breakout_cfg_create branch December 15, 2019 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a new function to create BRKOUT_CFG TABLE in config db #17

Adding a new function to create BRKOUT_CFG TABLE in config db #17

samaity commented Dec 11, 2019 •

edited

Loading

Adding a new function to create BRKOUT_CFG TABLE in config db #17

Adding a new function to create BRKOUT_CFG TABLE in config db #17

Conversation

samaity commented Dec 11, 2019 • edited Loading

samaity commented Dec 11, 2019 •

edited

Loading