Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[_sonic_yang_ext.py]: Parse multilist in YANG Container. #38

Merged
merged 3 commits into from
Feb 13, 2020
Merged

[_sonic_yang_ext.py]: Parse multilist in YANG Container. #38

merged 3 commits into from
Feb 13, 2020

Conversation

praveen-li
Copy link
Collaborator

@praveen-li praveen-li commented Feb 7, 2020 •
edited
Loading

Note: Please review from 3rd commit onwards. I will rebase after this PR approval and other PR merge.

- What I did
[_sonic_yang_ext.py]: Parse multilist in YANG Container.

This is needed to support VRF feature in SONiC.

- How I did it

By Writing more accurate regex while translation.
By allowing continue processing of primary key in config DB even when pkey does not matches with one of the list.

- How to verify it
Test Case already exist in sonic-yang-mgmt build system, so I just changed the sample config and built the Package.

pchaudha@e8879b00ab3e:/sonic$ make -f slave.mk target/python-wheels/sonic_yang_mgmt-1.0-py2-none-any.whl
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "broadcom"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "YourPaSsWoRd"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : ""
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : ""
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

pchaudha@e8879b00ab3e:/sonic$

Built SONIC yang mgmt again:

pchaudha@e8879b00ab3e:/sonic$ make -f slave.mk target/python-wheels/sonic_yang_mgmt-1.0-py2-none-any.whl
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "broadcom"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "YourPaSsWoRd"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : ""
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : ""
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

pchaudha@e8879b00ab3e:/sonic$

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@zhenggen-xu
Copy link
Owner

Please rebase the code as the other PR was merged.

[_sonic_yang_ext.py]: Parse multilist in YANG Container.
d06b225 
This is needed to support VRF feature in SONiC.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@vasant17
Copy link
Collaborator

vasant17 commented Feb 11, 2020 •
edited
Loading

Please make admin_status optional for VLAN and PORT

@vasant17 vasant17 self-requested a review February 11, 2020 19:30
Praveen Chaudhary added 2 commits February 11, 2020 16:07
[sonic-vlan.yang]: Change Vlan yang models to remove admin-status as …
1e62a91 
…mandatory attribute.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
[_sonic_yang_ext.py]: Minor fix in _sonic_yang_ext.py
9d2e41e 
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@zhenggen-xu zhenggen-xu merged commit aa7d8bf into zhenggen-xu:sonic-cfg-mgmt Feb 13, 2020
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 12, 2020
@jleveque
[sonic-telemetry][sonic-mgmt-common] Update submodules (sonic-net#4986)
2890670 
* src/sonic-telemetry fa8d498...3bd7ca3 (4):
  > Update gnmi deps (zhenggen-xu#40)
  > [testdata] Update SFP keys to align with new standard (zhenggen-xu#39)
  > Fixed the parameters for subscribe APIs (zhenggen-xu#38)
  > Azure ro mode (zhenggen-xu#34)

* src/sonic-mgmt-common 444aa9a...cc01ce4 (4):
  > Make gnmi dep version the same as in telemetry repo (zhenggen-xu#17)
  > Cleanup translib and cvl go test cases (zhenggen-xu#13)
  > Package update and enhancements/fixes in YGOT, and Request Binder (zhenggen-xu#12)
  > Translib phase I changes (zhenggen-xu#11)

Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Apr 27, 2021
@abdosi
[submodule update] sonic-db-syncd (sonic-net#7225)
38258ac 
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (zhenggen-xu#39)
e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (zhenggen-xu#38)
3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (zhenggen-xu#35)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 9, 2022
@zjswhhh
[sonic-linkmgrd][master] submodule update (sonic-net#10271)
64822d8 
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (zhenggen-xu#41)
ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (zhenggen-xu#39)
ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (zhenggen-xu#36)
c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (zhenggen-xu#38)
b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (zhenggen-xu#37)
bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (zhenggen-xu#28)
9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md
c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (zhenggen-xu#33)
b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (zhenggen-xu#31)
9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (zhenggen-xu#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasant17 vasant17 vasant17 approved these changes

@zhenggen-xu zhenggen-xu Awaiting requested review from zhenggen-xu

@li-pingmao li-pingmao Awaiting requested review from li-pingmao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveen-li @zhenggen-xu @vasant17