Fix sonic-cfggen --hwsku|-k command #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sangita Maity sangitamaity0211@gmail.com
sonic-cfggen -H -k
was not properly rendering the data. It was always reading fromconfig db
first, then platform.json and portconfig_ini respectively which is not the correct behavior.- What I did
Now it's reading data from respective
platform.json
. So we get correct output.- How I did it
checking the
args.port_config
variable. If it's not mentioned, then filename gets provided byget_port_config_file_name
function by default.- How to verify it
checked the output for all kind of HWSKUs.
attached two outputs.